Skip to content

only run objc tests in their own separate job#17098

Merged
jtattermusch merged 1 commit intogrpc:masterfrom
jtattermusch:objc_only_run_separately
Nov 5, 2018
Merged

only run objc tests in their own separate job#17098
jtattermusch merged 1 commit intogrpc:masterfrom
jtattermusch:objc_only_run_separately

Conversation

@jtattermusch
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch commented Nov 5, 2018

Supersedes #17071

Followup for #17068, addressing concerns from #17071.

  • don't run objc as part of macos basictests, but do that by explicitly excluding them from the basictests suite (which feels like the cleanest thing to do).
  • other concerns (like Only run objc tests in its own separate job #17071 (comment)) shall be addressed separately, right now the ObjC test are running twice on PRs (once as part of the "basictests" job, once in its own separate job) and that wasting resources and we should address that quickly.

@jtattermusch jtattermusch added lang/ObjC release notes: no Indicates if PR should not be in release notes labels Nov 5, 2018
@jtattermusch jtattermusch mentioned this pull request Nov 5, 2018
Closed
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 5, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 5, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 5, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,016,505      Total (=)      2,016,505

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,123,082      Total (>)     11,123,072

 No significant differences in binary sizes

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Nov 5, 2018 

Corrupt JSON data (indicates timeout or crash): 
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10


[microbenchmarks] No significant performance differences

@jtattermusch jtattermusch merged commit ece3c40 into grpc:master Nov 5, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Feb 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@muxi muxi muxi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@muxi muxi

Labels

lang/ObjC release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtattermusch @grpc-testing @muxi