Prefer lambda expressions over std::bind by yashykt · Pull Request #17090 · grpc/grpc

yashykt · 2018-11-02T22:49:18Z

Prefer lambda expressions over std::bind.
Fixes #17048

grpc-testing · 2018-11-02T22:54:27Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE                                                                                            FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
  +1.5%    +725 src/cpp/server/server_cc.cc                                                             +725  +1.5%
      +109%    +465 grpc::ServerAsyncReaderWriter<grpc::ByteBuffer, grpc::ByteBuffer>::WriteAndFinish       +465  +109%
       +40%    +452 grpc::Server::UnimplementedAsyncResponse::UnimplementedAsyncResponse                    +452   +40%
      [NEW]    +200 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    +200  [NEW]
       +17%    +198 grpc::Server::~Server                                                                   +198   +17%
      +8.5%    +153 grpc::Server::SyncRequestThreadManager::DoWork                                          +153  +8.5%
      [NEW]     +46 std::_Function_base::_Base_manager<grpc::ServerInterface::BaseAsyncRequest::Finalize     +46  [NEW]
      [NEW]     +46 std::_Function_base::_Base_manager<grpc::Server::SyncRequest::CallData::Run(std::sha     +46  [NEW]
      +1.8%     +12 [Unmapped]                                                                               +12  +1.8%
      [NEW]      +8 std::_Function_handler<void (), grpc::ServerInterface::BaseAsyncRequest::FinalizeRes      +8  [NEW]
      [NEW]      +8 std::_Function_handler<void (), grpc::Server::SyncRequest::CallData::Run(std::shared      +8  [NEW]
  +3.9%    +295 src/cpp/client/secure_credentials.cc                                                    +295  +3.9%
      [NEW]    +200 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    +200  [NEW]
       +22%    +138 grpc::MetadataCredentialsPluginWrapper::GetMetadata                                     +138   +22%
      [NEW]    +137 std::_Function_base::_Base_manager<grpc::MetadataCredentialsPluginWrapper::GetMetada    +137  [NEW]
      [NEW]    +137 std::_Function_base::_Base_manager<grpc::MetadataCredentialsPluginWrapper::GetMetada    +137  [NEW]
      [NEW]     +50 std::_Function_handler<void (), grpc::MetadataCredentialsPluginWrapper::GetMetadata(     +50  [NEW]
      [NEW]     +50 std::_Function_handler<void (), grpc::MetadataCredentialsPluginWrapper::GetMetadata(     +50  [NEW]
       +18%     +30 [Unmapped]                                                                               +30   +18%

 -------------- SHRINKING                                                                            --------------
  -2.1% -6.48Ki [None]                                                                                -138Ki  -1.7%
      -2.0% -5.60Ki [Unmapped]                                                                            -137Ki  -1.7%
      [DEL]    -169 typeinfo name for std::_Bind<void (grpc::MetadataCredentialsPluginWrapper::*(grpc::M    -169  [DEL]
      [DEL]    -164 typeinfo name for std::_Weak_result_type_impl<void (grpc::MetadataCredentialsPluginW    -164  [DEL]
      [DEL]    -159 typeinfo name for std::_Weak_result_type<void (grpc::MetadataCredentialsPluginWrappe    -159  [DEL]
      [DEL]    -151 typeinfo name for std::_Bind<void (grpc::AuthMetadataProcessorAyncWrapper::*(grpc::A    -151  [DEL]
      [DEL]    -150 typeinfo name for std::_Weak_result_type_impl<void (grpc::AuthMetadataProcessorAyncW    -150  [DEL]
      [DEL]    -145 typeinfo name for std::_Weak_result_type<void (grpc::AuthMetadataProcessorAyncWrappe    -145  [DEL]
      [DEL]     -88 [Other]                                                                                  -88  [DEL]
      [DEL]     -76 typeinfo name for std::_Weak_result_type_impl<void (grpc::ServerInterface::BaseAsync     -76  [DEL]
      [DEL]     -71 typeinfo name for std::_Weak_result_type<void (grpc::ServerInterface::BaseAsyncReque     -71  [DEL]
      [DEL]     -70 typeinfo name for std::_Weak_result_type_impl<void (grpc::Server::SyncRequest::CallD     -70  [DEL]
      [DEL]     -65 typeinfo name for std::_Weak_result_type<void (grpc::Server::SyncRequest::CallData::     -65  [DEL]
      [DEL]     -64 typeinfo name for std::_Bind<void (grpc::ServerInterface::BaseAsyncRequest::*(grpc::     -64  [DEL]
      [DEL]     -58 typeinfo name for std::_Bind<void (grpc::Server::SyncRequest::CallData::*(grpc::Serv     -58  [DEL]
      [DEL]     -24 typeinfo for std::_Weak_result_type<void (grpc::ServerInterface::BaseAsyncRequest::*     -24  [DEL]
      [DEL]     -24 typeinfo for std::_Weak_result_type<void (grpc::AuthMetadataProcessorAyncWrapper::*)     -24  [DEL]
      [DEL]     -24 typeinfo for std::_Weak_result_type<void (grpc::MetadataCredentialsPluginWrapper::*)     -24  [DEL]
      [DEL]     -24 typeinfo for std::_Weak_result_type<void (grpc::Server::SyncRequest::CallData::*)()>     -24  [DEL]
      [DEL]     -24 typeinfo for std::_Bind<void (grpc::ServerInterface::BaseAsyncRequest::*(grpc::Serve     -24  [DEL]
      [DEL]     -24 typeinfo for std::_Bind<void (grpc::AuthMetadataProcessorAyncWrapper::*(grpc::AuthMe     -24  [DEL]
      [DEL]     -24 typeinfo for std::_Bind<void (grpc::MetadataCredentialsPluginWrapper::*(grpc::Metada     -24  [DEL]
  -0.2%     -11 src/cpp/server/secure_server_credentials.cc                                              -11  -0.2%
      [DEL]    -137 std::_Function_base::_Base_manager<std::_Bind<void (grpc::AuthMetadataProcessorAyncW    -137  [DEL]
      [DEL]     -48 std::_Function_handler<void (), std::_Bind<void (grpc::AuthMetadataProcessorAyncWrap     -48  [DEL]
      -3.8%     -16 grpc::AuthMetadataProcessorAyncWrapper::Process                                          -16  -3.8%

  -1.0% -5.50Ki TOTAL                                                                                 -137Ki  -1.7%

grpc-testing · 2018-11-02T23:02:18Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE                                                                                            FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
  +1.5%    +725 src/cpp/server/server_cc.cc                                                             +725  +1.5%
      +109%    +465 grpc::ServerAsyncReaderWriter<grpc::ByteBuffer, grpc::ByteBuffer>::WriteAndFinish       +465  +109%
       +40%    +452 grpc::Server::UnimplementedAsyncResponse::UnimplementedAsyncResponse                    +452   +40%
      [NEW]    +200 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    +200  [NEW]
       +17%    +198 grpc::Server::~Server                                                                   +198   +17%
      +8.5%    +153 grpc::Server::SyncRequestThreadManager::DoWork                                          +153  +8.5%
      [NEW]     +46 std::_Function_base::_Base_manager<grpc::ServerInterface::BaseAsyncRequest::Finalize     +46  [NEW]
      [NEW]     +46 std::_Function_base::_Base_manager<grpc::Server::SyncRequest::CallData::Run(std::sha     +46  [NEW]
      +1.8%     +12 [Unmapped]                                                                               +12  +1.8%
      [NEW]      +8 std::_Function_handler<void (), grpc::ServerInterface::BaseAsyncRequest::FinalizeRes      +8  [NEW]
      [NEW]      +8 std::_Function_handler<void (), grpc::Server::SyncRequest::CallData::Run(std::shared      +8  [NEW]

 -------------- SHRINKING                                                                            --------------
  -2.2% -6.81Ki [None]                                                                                -143Ki  -1.8%
      -2.1% -5.77Ki [Unmapped]                                                                            -142Ki  -1.8%
      [DEL]    -169 typeinfo name for std::_Bind<void (grpc::MetadataCredentialsPluginWrapper::*(grpc::M    -169  [DEL]
      [DEL]    -164 typeinfo name for std::_Weak_result_type_impl<void (grpc::MetadataCredentialsPluginW    -164  [DEL]
      [DEL]    -159 typeinfo name for std::_Weak_result_type<void (grpc::MetadataCredentialsPluginWrappe    -159  [DEL]
      [DEL]    -151 typeinfo name for std::_Bind<void (grpc::AuthMetadataProcessorAyncWrapper::*(grpc::A    -151  [DEL]
      [DEL]    -150 typeinfo name for std::_Weak_result_type_impl<void (grpc::AuthMetadataProcessorAyncW    -150  [DEL]
      [DEL]    -145 typeinfo name for std::_Weak_result_type<void (grpc::AuthMetadataProcessorAyncWrappe    -145  [DEL]
      [DEL]     -88 [Other]                                                                                  -88  [DEL]
      [DEL]     -76 typeinfo name for std::_Weak_result_type_impl<void (grpc::ServerInterface::BaseAsync     -76  [DEL]
      [DEL]     -71 typeinfo name for std::_Weak_result_type<void (grpc::ServerInterface::BaseAsyncReque     -71  [DEL]
      [DEL]     -70 typeinfo name for std::_Weak_result_type_impl<void (grpc::Server::SyncRequest::CallD     -70  [DEL]
      [DEL]     -65 typeinfo name for std::_Weak_result_type<void (grpc::Server::SyncRequest::CallData::     -65  [DEL]
      [DEL]     -64 typeinfo name for std::_Bind<void (grpc::ServerInterface::BaseAsyncRequest::*(grpc::     -64  [DEL]
      [DEL]     -58 typeinfo name for std::_Bind<void (grpc::Server::SyncRequest::CallData::*(grpc::Serv     -58  [DEL]
      [DEL]     -24 typeinfo for std::_Weak_result_type<void (grpc::ServerInterface::BaseAsyncRequest::*     -24  [DEL]
      [DEL]     -24 typeinfo for std::_Weak_result_type<void (grpc::AuthMetadataProcessorAyncWrapper::*)     -24  [DEL]
      [DEL]     -24 typeinfo for std::_Weak_result_type<void (grpc::MetadataCredentialsPluginWrapper::*)     -24  [DEL]
      [DEL]     -24 typeinfo for std::_Weak_result_type<void (grpc::Server::SyncRequest::CallData::*)()>     -24  [DEL]
      [DEL]     -24 typeinfo for std::_Bind<void (grpc::ServerInterface::BaseAsyncRequest::*(grpc::Serve     -24  [DEL]
      [DEL]     -24 typeinfo for std::_Bind<void (grpc::AuthMetadataProcessorAyncWrapper::*(grpc::AuthMe     -24  [DEL]
      [DEL]     -24 typeinfo for std::_Bind<void (grpc::MetadataCredentialsPluginWrapper::*(grpc::Metada     -24  [DEL]
  -1.2%     -89 src/cpp/client/secure_credentials.cc                                                     -89  -1.2%
      [DEL]    -200 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    -200  [DEL]
      [DEL]    -169 std::_Function_base::_Base_manager<std::_Bind<void (grpc::MetadataCredentialsPluginW    -169  [DEL]
      [DEL]     -78 std::_Function_handler<void (), std::_Bind<void (grpc::MetadataCredentialsPluginWrap     -78  [DEL]
      -7.6%     -48 grpc::MetadataCredentialsPluginWrapper::GetMetadata                                      -48  -7.6%
  -0.2%     -11 src/cpp/server/secure_server_credentials.cc                                              -11  -0.2%
      [DEL]    -137 std::_Function_base::_Base_manager<std::_Bind<void (grpc::AuthMetadataProcessorAyncW    -137  [DEL]
      [DEL]     -48 std::_Function_handler<void (), std::_Bind<void (grpc::AuthMetadataProcessorAyncWrap     -48  [DEL]
      -3.8%     -16 grpc::AuthMetadataProcessorAyncWrapper::Process                                          -16  -3.8%

  -1.2% -6.20Ki TOTAL                                                                                 -142Ki  -1.7%

grpc-testing · 2018-11-02T23:04:48Z

[trickle] No significant performance differences

grpc-testing · 2018-11-02T23:10:45Z

[trickle] No significant performance differences

grpc-testing · 2018-11-02T23:34:54Z

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,016,505      Total (=)      2,016,505

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,123,084      Total (<)     11,123,086

 No significant differences in binary sizes

grpc-testing · 2018-11-02T23:43:42Z

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,016,505      Total (=)      2,016,505

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,123,081      Total (>)     11,123,078

 No significant differences in binary sizes

grpc-testing · 2018-11-02T23:46:17Z

Corrupt JSON data (indicates timeout or crash): 
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10


[microbenchmarks] No significant performance differences

grpc-testing · 2018-11-02T23:54:18Z

Corrupt JSON data (indicates timeout or crash): 
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10


[microbenchmarks] No significant performance differences

hcaseyal

LGTM

OBorce · 2018-11-05T17:58:49Z

src/cpp/client/secure_credentials.cc

-    w->thread_pool_->Add(
-        std::bind(&MetadataCredentialsPluginWrapper::InvokePlugin, w, context,
-                  cb, user_data, nullptr, nullptr, nullptr, nullptr));
+    w->thread_pool_->Add([=]() {


The empty () are unnecessary and can be left out.

Suggested change

w->thread_pool_->Add([=]() {

w->thread_pool_->Add([=] {

Same thing below.

I agree with this comment.

But see my overall request about anonymous captures.

vjpai

IMMEDIATE LBTM.
We cannot use anonymous lambda captures.

hcaseyal · 2018-11-05T18:20:50Z

@vjpai Why can't we use anonymous lambda captures?

vjpai · 2018-11-05T18:31:43Z

Anonymous lambda captures are error-prone and imprecise; although people say that about auto, this is a worse situation since these can easily lead to dangling pointer bugs when some new variable comes along. I think we've allowed in maybe 1 or 2 into our whole codebase and that was where there really was no other option because of some other issue. The Bible no longer forbids them but also strongly doesn't prefer them.

grpc-testing · 2018-11-05T20:21:27Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE                                                                                            FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
  +1.5%    +725 src/cpp/server/server_cc.cc                                                             +725  +1.5%
      +109%    +465 grpc::ServerAsyncReaderWriter<grpc::ByteBuffer, grpc::ByteBuffer>::WriteAndFinish       +465  +109%
       +40%    +452 grpc::Server::UnimplementedAsyncResponse::UnimplementedAsyncResponse                    +452   +40%
      [NEW]    +200 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    +200  [NEW]
       +17%    +198 grpc::Server::~Server                                                                   +198   +17%
      +8.5%    +153 grpc::Server::SyncRequestThreadManager::DoWork                                          +153  +8.5%
      [NEW]     +46 std::_Function_base::_Base_manager<grpc::ServerInterface::BaseAsyncRequest::Finalize     +46  [NEW]
      [NEW]     +46 std::_Function_base::_Base_manager<grpc::Server::SyncRequest::CallData::Run(std::sha     +46  [NEW]
      +1.8%     +12 [Unmapped]                                                                               +12  +1.8%
      [NEW]      +8 std::_Function_handler<void (), grpc::ServerInterface::BaseAsyncRequest::FinalizeRes      +8  [NEW]
      [NEW]      +8 std::_Function_handler<void (), grpc::Server::SyncRequest::CallData::Run(std::shared      +8  [NEW]

 -------------- SHRINKING                                                                            --------------
  -2.2% -6.81Ki [None]                                                                                -143Ki  -1.8%
      -2.1% -5.77Ki [Unmapped]                                                                            -142Ki  -1.8%
      [DEL]    -169 typeinfo name for std::_Bind<void (grpc::MetadataCredentialsPluginWrapper::*(grpc::M    -169  [DEL]
      [DEL]    -164 typeinfo name for std::_Weak_result_type_impl<void (grpc::MetadataCredentialsPluginW    -164  [DEL]
      [DEL]    -159 typeinfo name for std::_Weak_result_type<void (grpc::MetadataCredentialsPluginWrappe    -159  [DEL]
      [DEL]    -151 typeinfo name for std::_Bind<void (grpc::AuthMetadataProcessorAyncWrapper::*(grpc::A    -151  [DEL]
      [DEL]    -150 typeinfo name for std::_Weak_result_type_impl<void (grpc::AuthMetadataProcessorAyncW    -150  [DEL]
      [DEL]    -145 typeinfo name for std::_Weak_result_type<void (grpc::AuthMetadataProcessorAyncWrappe    -145  [DEL]
      [DEL]     -88 [Other]                                                                                  -88  [DEL]
      [DEL]     -76 typeinfo name for std::_Weak_result_type_impl<void (grpc::ServerInterface::BaseAsync     -76  [DEL]
      [DEL]     -71 typeinfo name for std::_Weak_result_type<void (grpc::ServerInterface::BaseAsyncReque     -71  [DEL]
      [DEL]     -70 typeinfo name for std::_Weak_result_type_impl<void (grpc::Server::SyncRequest::CallD     -70  [DEL]
      [DEL]     -65 typeinfo name for std::_Weak_result_type<void (grpc::Server::SyncRequest::CallData::     -65  [DEL]
      [DEL]     -64 typeinfo name for std::_Bind<void (grpc::ServerInterface::BaseAsyncRequest::*(grpc::     -64  [DEL]
      [DEL]     -58 typeinfo name for std::_Bind<void (grpc::Server::SyncRequest::CallData::*(grpc::Serv     -58  [DEL]
      [DEL]     -24 typeinfo for std::_Weak_result_type<void (grpc::ServerInterface::BaseAsyncRequest::*     -24  [DEL]
      [DEL]     -24 typeinfo for std::_Weak_result_type<void (grpc::AuthMetadataProcessorAyncWrapper::*)     -24  [DEL]
      [DEL]     -24 typeinfo for std::_Weak_result_type<void (grpc::MetadataCredentialsPluginWrapper::*)     -24  [DEL]
      [DEL]     -24 typeinfo for std::_Weak_result_type<void (grpc::Server::SyncRequest::CallData::*)()>     -24  [DEL]
      [DEL]     -24 typeinfo for std::_Bind<void (grpc::ServerInterface::BaseAsyncRequest::*(grpc::Serve     -24  [DEL]
      [DEL]     -24 typeinfo for std::_Bind<void (grpc::AuthMetadataProcessorAyncWrapper::*(grpc::AuthMe     -24  [DEL]
      [DEL]     -24 typeinfo for std::_Bind<void (grpc::MetadataCredentialsPluginWrapper::*(grpc::Metada     -24  [DEL]
  -1.2%     -89 src/cpp/client/secure_credentials.cc                                                     -89  -1.2%
      [DEL]    -200 void std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >    -200  [DEL]
      [DEL]    -169 std::_Function_base::_Base_manager<std::_Bind<void (grpc::MetadataCredentialsPluginW    -169  [DEL]
      [DEL]     -78 std::_Function_handler<void (), std::_Bind<void (grpc::MetadataCredentialsPluginWrap     -78  [DEL]
      -7.6%     -48 grpc::MetadataCredentialsPluginWrapper::GetMetadata                                      -48  -7.6%
  -0.2%     -11 src/cpp/server/secure_server_credentials.cc                                              -11  -0.2%
      [DEL]    -137 std::_Function_base::_Base_manager<std::_Bind<void (grpc::AuthMetadataProcessorAyncW    -137  [DEL]
      [DEL]     -48 std::_Function_handler<void (), std::_Bind<void (grpc::AuthMetadataProcessorAyncWrap     -48  [DEL]
      -3.8%     -16 grpc::AuthMetadataProcessorAyncWrapper::Process                                          -16  -3.8%

  -1.2% -6.20Ki TOTAL                                                                                 -142Ki  -1.7%

grpc-testing · 2018-11-05T20:31:48Z

[trickle] No significant performance differences

grpc-testing · 2018-11-05T21:03:30Z

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,020,616      Total (=)      2,020,616

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,180,941      Total (>)     11,180,936

 No significant differences in binary sizes

grpc-testing · 2018-11-05T21:14:20Z

Corrupt JSON data (indicates timeout or crash): 
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10


[microbenchmarks] No significant performance differences

yashykt · 2018-11-05T21:41:01Z

All green! Thanks for reviewing!

hcaseyal · 2018-11-05T21:43:55Z

@vjpai Thanks for the explanation! Makes sense.

yashykt requested a review from hcaseyal November 2, 2018 22:49

yashykt assigned hcaseyal Nov 2, 2018

yashykt added lang/c++ release notes: no Indicates if PR should not be in release notes labels Nov 2, 2018

Prefer lambda expressions over std::bind

e08a2b3

yashykt force-pushed the minor_cleanup1 branch from 8434790 to e08a2b3 Compare November 2, 2018 22:57

hcaseyal approved these changes Nov 5, 2018

View reviewed changes

OBorce reviewed Nov 5, 2018

View reviewed changes

vjpai suggested changes Nov 5, 2018

View reviewed changes

Don't use default capture

f856195

vjpai approved these changes Nov 5, 2018

View reviewed changes

yashykt merged commit 673887d into grpc:master Nov 5, 2018

hcaseyal mentioned this pull request Nov 6, 2018

Eliminate function pointers in hpack_enc(). #17102

Merged

lock bot locked as resolved and limited conversation to collaborators Feb 3, 2019

yashykt deleted the minor_cleanup1 branch May 18, 2023 20:33

Conversation

yashykt commented Nov 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

grpc-testing commented Nov 2, 2018

Uh oh!

grpc-testing commented Nov 2, 2018

Uh oh!

grpc-testing commented Nov 2, 2018

Uh oh!

grpc-testing commented Nov 2, 2018

Uh oh!

grpc-testing commented Nov 2, 2018

Uh oh!

grpc-testing commented Nov 2, 2018

Uh oh!

grpc-testing commented Nov 2, 2018

Uh oh!

grpc-testing commented Nov 2, 2018

Uh oh!

hcaseyal left a comment

Choose a reason for hiding this comment

Uh oh!

OBorce Nov 5, 2018

Choose a reason for hiding this comment

Uh oh!

vjpai Nov 5, 2018

Choose a reason for hiding this comment

Uh oh!

vjpai Nov 5, 2018

Choose a reason for hiding this comment

Uh oh!

yashykt Nov 5, 2018

Choose a reason for hiding this comment

Uh oh!

vjpai left a comment

Choose a reason for hiding this comment

Uh oh!

hcaseyal commented Nov 5, 2018

Uh oh!

vjpai commented Nov 5, 2018

Uh oh!

grpc-testing commented Nov 5, 2018

Uh oh!

grpc-testing commented Nov 5, 2018

Uh oh!

grpc-testing commented Nov 5, 2018

Uh oh!

grpc-testing commented Nov 5, 2018

Uh oh!

yashykt commented Nov 5, 2018

Uh oh!

hcaseyal commented Nov 5, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

yashykt commented Nov 2, 2018 •

edited

Loading