Skip to content

Minor Cleanup#17085

Merged
yashykt merged 1 commit intogrpc:masterfrom
yashykt:minor_cleanup
Nov 5, 2018
Merged

Minor Cleanup#17085
yashykt merged 1 commit intogrpc:masterfrom
yashykt:minor_cleanup

Conversation

@yashykt
Copy link
Copy Markdown
Member

@yashykt yashykt commented Nov 2, 2018

s/new/post-1.0

@grpc-testing
Copy link
Copy Markdown

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]



@yashykt yashykt added release notes: no Indicates if PR should not be in release notes lang/c++ labels Nov 2, 2018
@grpc-testing
Copy link
Copy Markdown

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,016,509      Total (=)      2,016,509

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,123,087      Total (>)     11,123,082

 No significant differences in binary sizes


@grpc-testing
Copy link
Copy Markdown

Corrupt JSON data (indicates timeout or crash): 
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10


[microbenchmarks] No significant performance differences

@yashykt
Copy link
Copy Markdown
Member Author

yashykt commented Nov 5, 2018

Doc change but still.. Known issues #16042
Thanks for reviewing!

@yashykt yashykt merged commit e4faafa into grpc:master Nov 5, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Feb 3, 2019
@yashykt yashykt deleted the minor_cleanup branch May 18, 2023 20:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lang/c++ release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants