Skip to content

Only run objc tests in its own separate job#17071

Closed
jtattermusch wants to merge 1 commit intogrpc:masterfrom
jtattermusch:objc_run_in_separate_job
Closed

Only run objc tests in its own separate job#17071
jtattermusch wants to merge 1 commit intogrpc:masterfrom
jtattermusch:objc_run_in_separate_job

Conversation

@jtattermusch
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch commented Oct 31, 2018

Followup for #17068

  • don't run objc as part of macos basictests
  • run it in its own job (both on PRs and on master)

@jtattermusch jtattermusch added lang/ObjC release notes: no Indicates if PR should not be in release notes labels Oct 31, 2018
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Oct 31, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Oct 31, 2018 

[trickle] No significant performance differences

muxi
muxi suggested changes Oct 31, 2018
View reviewed changes
tools/internal_ci/macos/grpc_basictests_objc_dbg.cfg
env_vars {
key: "RUN_TESTS_FLAGS"
value: "-f basictests macos objc dbg --internal_ci -j 1 --inner_jobs 4 --bq_result_table aggregate_results"
value: "-f macos objc dbg --internal_ci -j 1 --inner_jobs 4 --bq_result_table aggregate_results"
Copy link
Copy Markdown
Contributor

@muxi muxi Oct 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The names of the config files are still basictests though

Copy link
Copy Markdown
Contributor

@muxi muxi Nov 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I recommend renaming these tests ios rather than objc so that other tests (cpp in #17058, for example) on iOS could also use it, eliminating the huge overhead like downloading master repo of Cocoapods

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Oct 31, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,015,649      Total (=)      2,015,649

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,116,198      Total (=)     11,116,198

 No significant differences in binary sizes

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Oct 31, 2018 

Corrupt JSON data (indicates timeout or crash): 
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10


[microbenchmarks] No significant performance differences

@jtattermusch jtattermusch mentioned this pull request Nov 5, 2018
Merged
@jtattermusch
Copy link
Copy Markdown
Contributor Author

jtattermusch commented Nov 5, 2018

Closing in favor of #17098

@lock lock bot locked as resolved and limited conversation to collaborators Feb 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@muxi muxi muxi requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@muxi muxi

Labels

lang/ObjC release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtattermusch @grpc-testing @muxi