Skip to content

Add separate kokoro jobs for objc tests#17068

Merged
jtattermusch merged 1 commit intogrpc:masterfrom
jtattermusch:objc_kokoro_jobs
Oct 31, 2018
Merged

Add separate kokoro jobs for objc tests#17068
jtattermusch merged 1 commit intogrpc:masterfrom
jtattermusch:objc_kokoro_jobs

Conversation

@jtattermusch
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch commented Oct 31, 2018

Mac tests currently run much longer than windows and linux tests.
Majority of the time is spent running objc tests as reported here #15657

Before we can figure out how to speed up objc tests, we can move objc tests to a separate job.
This PR prepares the kokoro .cfg files needed for that, the actual move from macos "basictests" jobs will happen in a followup PR.

@jtattermusch jtattermusch added lang/ObjC release notes: no Indicates if PR should not be in release notes labels Oct 31, 2018
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Oct 31, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Oct 31, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Oct 31, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,015,649      Total (=)      2,015,649

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,116,189      Total (<)     11,116,192

 No significant differences in binary sizes

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Oct 31, 2018 

Corrupt JSON data (indicates timeout or crash): 
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.new: 10
    bm_call_create.BM_IsolatedFilter_ClientChannelFilter_NoOp_.counters.old: 10


[microbenchmarks] No significant performance differences

@jtattermusch jtattermusch merged commit ff2ef97 into grpc:master Oct 31, 2018
This was referenced Oct 31, 2018
Closed
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@muxi muxi muxi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@muxi muxi

Labels

lang/ObjC release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtattermusch @grpc-testing @muxi