Skip to content

Bump version to 1.14.2#16487

Merged
nicolasnoble merged 2 commits intogrpc:v1.14.xfrom
srini100:v1.14.x
Aug 29, 2018
Merged

Bump version to 1.14.2#16487
nicolasnoble merged 2 commits intogrpc:v1.14.xfrom
srini100:v1.14.x

Conversation

@srini100
Copy link
Copy Markdown
Contributor

@srini100 srini100 commented Aug 28, 2018

Bump version to 1.14.2 and regenerate projects.

@srini100 srini100 added the release notes: no Indicates if PR should not be in release notes label Aug 28, 2018
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 28, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE                                    FILE SIZE
 ++++++++++++++ GROWING                      ++++++++++++++

 -------------- SHRINKING                    --------------
 -11.5%     -11 src/cpp/common/version_cc.cc     -11 -11.5%
     -22.0%     -11 grpc::Version[abi:cxx11]         -11 -22.0%

 -+-+-+-+-+-+-+ MIXED                        +-+-+-+-+-+-+-
  +0.0%     +11 [None]                          -109  -0.0%

  [ = ]       0 TOTAL                           -120  -0.0%

@AspirinSJL
Copy link
Copy Markdown
Contributor

AspirinSJL commented Aug 28, 2018

We are supposed to have closed this branch, right?

@mehrdada
Copy link
Copy Markdown
Contributor

mehrdada commented Aug 28, 2018

@AspirinSJL We close the branch so nothing gets accidentally committed. It does not prevent some people with additional permissions to click on the merge button. We occasionally push things to closed branches for various reasons (security bug fix backports). This PR is fine as it is intentional, but yes, we should close the branch so that only a few people can click on the merge button.

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 28, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 28, 2018 

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 29, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE                                    FILE SIZE
 ++++++++++++++ GROWING                      ++++++++++++++

 -------------- SHRINKING                    --------------
 -11.5%     -11 src/cpp/common/version_cc.cc     -11 -11.5%
     -22.0%     -11 grpc::Version[abi:cxx11]         -11 -22.0%

 -+-+-+-+-+-+-+ MIXED                        +-+-+-+-+-+-+-
  +0.0%     +11 [None]                          -109  -0.0%

  [ = ]       0 TOTAL                           -120  -0.0%

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 29, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 29, 2018 

[microbenchmarks] Performance differences noted:
Benchmark                                                                              cpu_time    real_time
-------------------------------------------------------------------------------------  ----------  -----------
BM_PumpStreamClientToServer<InProcess>/262144                                          -7%         -7%
BM_PumpStreamClientToServer<InProcess>/32768                                           -4%         -4%
BM_PumpStreamClientToServer<InProcessCHTTP2>/32768                                     -4%         -4%
BM_PumpStreamServerToClient<InProcess>/32768                                           -5%         -5%
BM_StreamingPingPong<InProcess, NoOpMutator, NoOpMutator>/262144/2                     -7%         -7%
BM_StreamingPingPongMsgs<InProcess, NoOpMutator, NoOpMutator>/32768                    -6%         -6%
BM_StreamingPingPongMsgs<MinInProcess, NoOpMutator, NoOpMutator>/262144                -7%         -7%
BM_StreamingPingPongMsgs<MinInProcess, NoOpMutator, NoOpMutator>/32768                 -5%         -5%
BM_StreamingPingPongMsgs<MinInProcessCHTTP2, NoOpMutator, NoOpMutator>/32768           -6%         -6%
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/262144/1/0  -7%         -7%
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/262144/2/0  -7%         -7%
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/0/2097152                     -6%         -6%
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/32768/32768                   -4%         -4%

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 29, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE                                    FILE SIZE
 ++++++++++++++ GROWING                      ++++++++++++++

 -------------- SHRINKING                    --------------
 -11.5%     -11 src/cpp/common/version_cc.cc     -11 -11.5%
     -22.0%     -11 grpc::Version[abi:cxx11]         -11 -22.0%

 -+-+-+-+-+-+-+ MIXED                        +-+-+-+-+-+-+-
  +0.0%     +11 [None]                          -109  -0.0%

  [ = ]       0 TOTAL                           -120  -0.0%

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 29, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 29, 2018 

[microbenchmarks] No significant performance differences

@nicolasnoble nicolasnoble merged commit d3e1604 into grpc:v1.14.x Aug 29, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 27, 2018
@lock lock bot unassigned mehrdada Nov 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@mehrdada mehrdada mehrdada approved these changes

@AspirinSJL AspirinSJL AspirinSJL approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@srini100 @grpc-testing @AspirinSJL @mehrdada @nicolasnoble @kokoro-team