Skip to content

Bump version to v1.14.2-pre1#16406

Merged
srini100 merged 2 commits intogrpc:v1.14.xfrom
srini100:versionbump
Aug 21, 2018
Merged

Bump version to v1.14.2-pre1#16406
srini100 merged 2 commits intogrpc:v1.14.xfrom
srini100:versionbump

Conversation

@srini100
Copy link
Copy Markdown
Contributor

@srini100 srini100 commented Aug 21, 2018

Bump version to v1.14.2-pre1. Stopped adding pre1 to core version.

@srini100 srini100 added the release notes: no Indicates if PR should not be in release notes label Aug 21, 2018
@srini100 srini100 requested a review from mehrdada August 21, 2018 00:54
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 21, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE                                    FILE SIZE
 ++++++++++++++ GROWING                      ++++++++++++++
   +13%     +11 src/cpp/common/version_cc.cc     +11   +13%
       +28%     +11 grpc::Version[abi:cxx11]         +11   +28%

 -+-+-+-+-+-+-+ MIXED                        +-+-+-+-+-+-+-
  -0.0%     -11 [None]                          +109  +0.0%

  [ = ]       0 TOTAL                           +120  +0.0%

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 21, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 21, 2018 

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 21, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE                                    FILE SIZE
 ++++++++++++++ GROWING                      ++++++++++++++
   +13%     +11 src/cpp/common/version_cc.cc     +11   +13%
       +28%     +11 grpc::Version[abi:cxx11]         +11   +28%

 -+-+-+-+-+-+-+ MIXED                        +-+-+-+-+-+-+-
  -0.0%     -11 [None]                          +109  +0.0%

  [ = ]       0 TOTAL                           +120  +0.0%

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 21, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 21, 2018 

[microbenchmarks] Performance differences noted:
Benchmark                                                                                 cpu_time    real_time
----------------------------------------------------------------------------------------  ----------  -----------
BM_PumpStreamServerToClient<InProcess>/32768                                              +6%         +6%
BM_StreamingPingPong<InProcess, NoOpMutator, NoOpMutator>/32768/1                         +6%         +6%
BM_StreamingPingPong<MinInProcess, NoOpMutator, NoOpMutator>/262144/1                     +7%         +7%
BM_StreamingPingPong<MinInProcess, NoOpMutator, NoOpMutator>/32768/1                      +4%         +4%
BM_StreamingPingPongMsgs<InProcess, NoOpMutator, NoOpMutator>/262144                      +7%         +7%
BM_StreamingPingPongMsgs<InProcess, NoOpMutator, NoOpMutator>/32768                       +8%         +8%
BM_StreamingPingPongMsgs<MinInProcess, NoOpMutator, NoOpMutator>/32768                    +8%         +8%
BM_StreamingPingPongMsgs<MinInProcessCHTTP2, NoOpMutator, NoOpMutator>/32768              +4%         +4%
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/262144/1/1     +5%         +5%
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/262144/2/1     +4%         +4%
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/32768/2/0      +5%         +5%
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/262144/1/1  +6%         +6%
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/262144/262144                    +5%         +5%

@srini100
Copy link
Copy Markdown
Contributor Author

srini100 commented Aug 21, 2018

Known Tsan C failure #16352
Python bazel failure seems related to infra.
Known MacOS failures on this branch.

@srini100 srini100 merged commit 4485af6 into grpc:v1.14.x Aug 21, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mehrdada mehrdada mehrdada approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@srini100 @grpc-testing @mehrdada @kokoro-team