Skip to content

Backport PRs #15929 and #16296 from master#16405

Merged
srini100 merged 2 commits intogrpc:v1.14.xfrom
srini100:v1.14.x
Aug 21, 2018
Merged

Backport PRs #15929 and #16296 from master#16405
srini100 merged 2 commits intogrpc:v1.14.xfrom
srini100:v1.14.x

Conversation

@srini100
Copy link
Copy Markdown
Contributor

@srini100 srini100 commented Aug 21, 2018

Backport PRs:
Don't segfault when product name from BIOS is empty #15929
Check if channel is closed before starting core ops #16296

nicolasnoble and others added 2 commits August 20, 2018 16:53
@nicolasnoble @srini100
Merge pull request grpc#15929 from Torgen/empty_product_name_segfault
aaa3162 
Don't segfault when product name from BIOS is empty
@ericgribkoff @srini100
Merge pull request grpc#16296 from ericgribkoff/close_segfault_fix
9969ac7 
Check if Python channel is closed before starting core ops
@srini100 srini100 requested a review from mehrdada August 21, 2018 00:14
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 21, 2018 

****************************************************************

libgrpc.so

     VM SIZE                                                                             FILE SIZE
 ++++++++++++++ GROWING                                                               ++++++++++++++
  +8.5%     +16 src/core/lib/security/credentials/alts/check_gcp_environment_linux.cc     +16  +8.5%
       +45%     +29 grpc_core::internal::check_bios_data                                      +29   +45%

 -+-+-+-+-+-+-+ MIXED                                                                 +-+-+-+-+-+-+-
  -0.0%     -16 [None]                                                                    +64  +0.0%

  [ = ]       0 TOTAL                                                                     +80  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@srini100 srini100 added the release notes: no Indicates if PR should not be in release notes label Aug 21, 2018
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 21, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 21, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 21, 2018 

[microbenchmarks] No significant performance differences

@srini100
Copy link
Copy Markdown
Contributor Author

srini100 commented Aug 21, 2018

Known MacOS failures on this branch.
Python bazel test is infra related.
Artifact build windows is successful but showing as pending.

@srini100 srini100 merged commit 08bf39a into grpc:v1.14.x Aug 21, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mehrdada mehrdada mehrdada approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@srini100 @grpc-testing @mehrdada @kokoro-team @nicolasnoble @ericgribkoff