Explictly Flush exec_ctx after resetting call_combiner_set_notify_on_…#16288
Merged
yashykt merged 1 commit intogrpc:masterfrom Aug 9, 2018
Merged
Explictly Flush exec_ctx after resetting call_combiner_set_notify_on_…#16288yashykt merged 1 commit intogrpc:masterfrom
yashykt merged 1 commit intogrpc:masterfrom
Conversation
…cancel to avoid the need to take refs on the stack for cancellation closures on exec_ctx
|
|
|
|
markdroth
approved these changes
Aug 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cancel to avoid the need to take refs on the stack for cancellation closures on exec_ctx