Skip to content

Explictly Flush exec_ctx after resetting call_combiner_set_notify_on_…#16288

Merged
yashykt merged 1 commit intogrpc:masterfrom
yashykt:combinernotify
Aug 9, 2018
Merged

Explictly Flush exec_ctx after resetting call_combiner_set_notify_on_…#16288
yashykt merged 1 commit intogrpc:masterfrom
yashykt:combinernotify

Conversation

@yashykt
Copy link
Copy Markdown
Member

@yashykt yashykt commented Aug 8, 2018

…cancel to avoid the need to take refs on the stack for cancellation closures on exec_ctx

…cancel to avoid the need to take refs on the stack for cancellation closures on exec_ctx
@grpc-testing
Copy link
Copy Markdown

****************************************************************

libgrpc.so

     VM SIZE                                                             FILE SIZE
 ++++++++++++++ GROWING                                               ++++++++++++++
  +0.0%      +8 [None]                                                   +360  +0.0%
  +0.2%     +32 src/core/lib/surface/call.cc                              +32  +0.2%
      +5.6%     +32 grpc_call_unref                                           +32  +5.6%

 -------------- SHRINKING                                             --------------
  -1.5%     -32 src/core/lib/security/transport/server_auth_filter.cc     -32  -1.5%
     -11.5%     -16 cancel_call                                               -16 -11.5%
     -11.9%      -8 [Unmapped]                                                 -8 -11.9%
      -1.2%      -8 recv_initial_metadata_ready                                -8  -1.2%
  -0.2%      -8 src/core/lib/security/transport/client_auth_filter.cc      -8  -0.2%
      -1.0%      -8 on_host_checked                                            -8  -1.0%
      -1.3%      -8 auth_start_transport_stream_op_batch                       -8  -1.3%
      -4.9%      -3 cancel_check_call_host                                     -3  -4.9%
      -4.5%      -2 cancel_get_request_metadata                                -2  -4.5%

  [ = ]       0 TOTAL                                                    +352  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]



@grpc-testing
Copy link
Copy Markdown

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,950,694      Total (<)      1,950,829

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,668,839      Total (>)     10,668,836

 No significant differences in binary sizes


@grpc-testing
Copy link
Copy Markdown

[microbenchmarks] No significant performance differences

@yashykt yashykt added the release notes: no Indicates if PR should not be in release notes label Aug 9, 2018
@yashykt
Copy link
Copy Markdown
Member Author

yashykt commented Aug 9, 2018

Known issues : #16304, #15489, #16230, #16285
Thanks for reviewing as always Mark!

@yashykt yashykt merged commit 4bdb0e3 into grpc:master Aug 9, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 7, 2018
@yashykt yashykt deleted the combinernotify branch May 18, 2023 19:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants