Skip to content

Revert "adding python version environmental markers in the new style"#16285

Merged
mehrdada merged 1 commit intomasterfrom
revert-16235-master
Aug 9, 2018
Merged

Revert "adding python version environmental markers in the new style"#16285
mehrdada merged 1 commit intomasterfrom
revert-16235-master

Conversation

@mehrdada
Copy link
Copy Markdown
Contributor

@mehrdada mehrdada commented Aug 8, 2018 •
edited
Loading

Reverts #16235 to see if it fixes #16270 (macOS Python failures)

@mehrdada mehrdada added release notes: no Indicates if PR should not be in release notes kind/bug lang/Python priority/P1 area/test disposition/BUILDNURSE For all buildnurse related build/test failures and flakes labels Aug 8, 2018
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 8, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,950,829      Total (=)      1,950,829

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,668,838      Total (<)     10,668,839

 No significant differences in binary sizes

@mehrdada mehrdada requested a review from srini100 August 8, 2018 17:53
@mehrdada
Copy link
Copy Markdown
Contributor Author

mehrdada commented Aug 8, 2018 •
edited
Loading

This seems to fix the pip issues on macOS opt, but surfaces another issue (timeout flake) with gevent AuthContext, but is strictly an improvement.

yashykt
yashykt approved these changes Aug 8, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@yashykt yashykt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamping

@mehrdada mehrdada merged commit 5059fd1 into master Aug 9, 2018
@mehrdada mehrdada deleted the revert-16235-master branch August 9, 2018 03:01
@yashykt yashykt mentioned this pull request Aug 9, 2018
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Nov 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yashykt yashykt yashykt approved these changes

@srini100 srini100 Awaiting requested review from srini100

Assignees

@srini100 srini100

Labels

area/test disposition/BUILDNURSE For all buildnurse related build/test failures and flakes kind/bug lang/Python priority/P1 release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

mac opt tests failing due to python install problem

4 participants

@mehrdada @grpc-testing @yashykt @srini100