Skip to content

Revert #15983 - gRPC channels blocking indefinitely and not respecting deadlines on network disconnect#16276

Merged
srini100 merged 1 commit intogrpc:v1.14.xfrom
srini100:v1.14.x
Aug 8, 2018
Merged

Revert #15983 - gRPC channels blocking indefinitely and not respecting deadlines on network disconnect#16276
srini100 merged 1 commit intogrpc:v1.14.xfrom
srini100:v1.14.x

Conversation

@srini100
Copy link
Copy Markdown
Contributor

@srini100 srini100 commented Aug 7, 2018

Revert #15983 - gRPC channels blocking indefinitely and not respecting deadlines on network disconnect

@srini100 srini100 requested a review from yashykt August 7, 2018 22:39
@srini100 srini100 added the release notes: no Indicates if PR should not be in release notes label Aug 7, 2018
yashykt
yashykt approved these changes Aug 7, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@yashykt yashykt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 7, 2018 

****************************************************************

libgrpc.so

     VM SIZE                                                                   FILE SIZE
 ++++++++++++++ GROWING                                                     ++++++++++++++

 -------------- SHRINKING                                                   --------------
  -0.1%    -648 [None]                                                      -2.45Ki  -0.0%
  -0.6%    -176 src/core/ext/transport/chttp2/transport/chttp2_transport.cc    -176  -0.6%
     -21.1%     -95 set_write_state                                                 -95 -21.1%
      -6.3%     -39 grpc_chttp2_complete_closure_step                               -39  -6.3%
      -1.2%     -29 grpc_chttp2_cancel_stream                                       -29  -1.2%
      -1.4%     -10 [Unmapped]                                                      -10  -1.4%
      -2.7%      -8 grpc_chttp2_add_ping_strike                                      -8  -2.7%
  -6.4%    -128 src/core/ext/transport/chttp2/transport/stream_lists.cc        -128  -6.4%
      [DEL]     -40 grpc_chttp2_list_add_waiting_for_write_stream                   -40  [DEL]
      [DEL]     -40 grpc_chttp2_list_remove_waiting_for_write_stream                -40  [DEL]
     -14.4%     -22 [Unmapped]                                                      -22 -14.4%
      -7.8%     -16 stream_list_id_string                                           -16  -7.8%
      [DEL]     -10 grpc_chttp2_list_pop_waiting_for_write_stream                   -10  [DEL]

  -0.1%    -952 TOTAL                                                       -2.75Ki  -0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 7, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 7, 2018 

[microbenchmarks] Performance differences noted:
Benchmark                                                                                 atm_add_per_iteration    cpu_time    real_time
----------------------------------------------------------------------------------------  -----------------------  ----------  -----------
BM_PumpStreamClientToServer<InProcess>/2097152                                                                     -8%         -8%
BM_PumpStreamClientToServer<InProcess>/262144                                                                      -7%         -7%
BM_PumpStreamServerToClient<InProcess>/2097152                                                                     -7%         -7%
BM_StreamCreateSendInitialMetadataDestroy<RepresentativeClientInitialMetadata>            -4%
BM_StreamingPingPong<InProcess, NoOpMutator, NoOpMutator>/262144/1                                                 -4%         -4%
BM_StreamingPingPong<MinInProcess, NoOpMutator, NoOpMutator>/262144/2                                              -4%         -4%
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/262144/1/1                              -8%         -8%
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/262144/2/1                              -9%         -9%
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/262144/1/1                           -4%         -4%
BM_TransportStreamSend/0                                                                  -12%
BM_TransportStreamSend/1                                                                  -11%
BM_TransportStreamSend/134217728                                                          -8%
BM_TransportStreamSend/16777216                                                           -9%
BM_TransportStreamSend/2097152                                                            -9%
BM_TransportStreamSend/262144                                                             -11%
BM_TransportStreamSend/32768                                                              -11%
BM_TransportStreamSend/4096                                                               -11%
BM_TransportStreamSend/512                                                                -11%
BM_TransportStreamSend/64                                                                 -11%
BM_TransportStreamSend/8                                                                  -11%
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/0/2097152                                                    -6%         -6%
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/0/262144                                                     -6%         -6%
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/0/2097152                                                 -5%         -5%
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/262144/262144                                             -6%         -6%

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 7, 2018 

****************************************************************

libgrpc.so

     VM SIZE                                                                   FILE SIZE
 ++++++++++++++ GROWING                                                     ++++++++++++++

 -------------- SHRINKING                                                   --------------
  -0.1%    -648 [None]                                                      -2.45Ki  -0.0%
  -0.6%    -176 src/core/ext/transport/chttp2/transport/chttp2_transport.cc    -176  -0.6%
     -21.1%     -95 set_write_state                                                 -95 -21.1%
      -6.3%     -39 grpc_chttp2_complete_closure_step                               -39  -6.3%
      -1.2%     -29 grpc_chttp2_cancel_stream                                       -29  -1.2%
      -1.4%     -10 [Unmapped]                                                      -10  -1.4%
      -2.7%      -8 grpc_chttp2_add_ping_strike                                      -8  -2.7%
  -6.4%    -128 src/core/ext/transport/chttp2/transport/stream_lists.cc        -128  -6.4%
      [DEL]     -40 grpc_chttp2_list_add_waiting_for_write_stream                   -40  [DEL]
      [DEL]     -40 grpc_chttp2_list_remove_waiting_for_write_stream                -40  [DEL]
     -14.4%     -22 [Unmapped]                                                      -22 -14.4%
      -7.8%     -16 stream_list_id_string                                           -16  -7.8%
      [DEL]     -10 grpc_chttp2_list_pop_waiting_for_write_stream                   -10  [DEL]

  -0.1%    -952 TOTAL                                                       -2.75Ki  -0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 8, 2018 

[trickle] No significant performance differences

@srini100
Copy link
Copy Markdown
Contributor Author

srini100 commented Aug 8, 2018

Known "out of space" error in MacOS test.
Bazel tests failing due to timeout.

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 8, 2018 

[microbenchmarks] Performance differences noted:
Benchmark                                                                       atm_add_per_iteration
------------------------------------------------------------------------------  -----------------------
BM_StreamCreateSendInitialMetadataDestroy<RepresentativeClientInitialMetadata>  -4%
BM_TransportStreamSend/0                                                        -12%
BM_TransportStreamSend/1                                                        -11%
BM_TransportStreamSend/134217728                                                -8%
BM_TransportStreamSend/16777216                                                 -9%
BM_TransportStreamSend/2097152                                                  -9%
BM_TransportStreamSend/262144                                                   -11%
BM_TransportStreamSend/32768                                                    -11%
BM_TransportStreamSend/4096                                                     -11%
BM_TransportStreamSend/512                                                      -11%
BM_TransportStreamSend/64                                                       -11%
BM_TransportStreamSend/8                                                        -11%

@srini100 srini100 merged commit d8020cb into grpc:v1.14.x Aug 8, 2018
@murgatroid99 murgatroid99 mentioned this pull request Aug 8, 2018
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Nov 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yashykt yashykt yashykt approved these changes

Assignees

No one assigned

Labels

release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@srini100 @grpc-testing @yashykt @kokoro-team