Skip to content

Build python3.7 32-bit packages on Windows#16255

Merged
mehrdada merged 2 commits intogrpc:v1.14.xfrom
mehrdada:backport-win32-python3.7
Aug 6, 2018
Merged

Build python3.7 32-bit packages on Windows#16255
mehrdada merged 2 commits intogrpc:v1.14.xfrom
mehrdada:backport-win32-python3.7

Conversation

@mehrdada
Copy link
Copy Markdown
Contributor

@mehrdada mehrdada commented Aug 6, 2018 •
edited
Loading

Backport #16111 into v1.14.x to build 32-bit Python 3.7 wheels for Windows. Addresses #15968 (after pushed to PyPI)

@mehrdada mehrdada requested a review from srini100 August 6, 2018 17:58
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 6, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 6, 2018 

[trickle] No significant performance differences

ericgribkoff
ericgribkoff reviewed Aug 6, 2018
View reviewed changes
tools/internal_ci/helper_scripts/prepare_build_windows.bat
@rem make sure msys binaries are preferred over cygwin binaries
@rem set path to python 2.7
set PATH=C:\tools\msys64\usr\bin;C:\Python27;C:\Python37;%PATH%
set PATH=C:\tools\msys64\usr\bin;C:\Python27;%PATH%
Copy link
Copy Markdown
Contributor

@ericgribkoff ericgribkoff Aug 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line differs from #16111?

Copy link
Copy Markdown
Contributor Author

@mehrdada mehrdada Aug 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closed the original in favor of getting this on master via the next upmerge to ensure they will be identical.

@mehrdada mehrdada mentioned this pull request Aug 6, 2018
Closed
@mehrdada mehrdada changed the title Backport #16111 into v1.14.x to build 32-bit Python 3.7 wheels for Windows Build python3.7 32-bit packages on Windows Aug 6, 2018
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 6, 2018 

[microbenchmarks] No significant performance differences

@mehrdada
Copy link
Copy Markdown
Contributor Author

mehrdada commented Aug 6, 2018 •
edited
Loading

Artifact/package build script modification: merging and invoking full artifact build fa172e97-996e-4d31-b6b4-1c7d4a374dca & distribtests in lieu of PR tests.

@mehrdada mehrdada merged commit 893776f into grpc:v1.14.x Aug 6, 2018
@mehrdada mehrdada deleted the backport-win32-python3.7 branch August 6, 2018 18:56
@mehrdada
Copy link
Copy Markdown
Contributor Author

mehrdada commented Aug 6, 2018 •
edited
Loading

Distribtests at cbe18191-147a-46b1-928b-02dba53f5569 SUCCESS

@mehrdada mehrdada added the release notes: yes Indicates if PR needs to be in release notes label Aug 6, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@srini100 srini100 Awaiting requested review from srini100

1 more reviewer

@ericgribkoff ericgribkoff ericgribkoff approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@srini100 srini100

Labels

kind/enhancement lang/Python priority/P1 release notes: yes Indicates if PR needs to be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mehrdada @grpc-testing @ericgribkoff @srini100