Skip to content

Reverts #16179#16242

Closed
ncteisen wants to merge 1 commit intogrpc:masterfrom
ncteisen:revert
Closed

Reverts #16179#16242
ncteisen wants to merge 1 commit intogrpc:masterfrom
ncteisen:revert

Conversation

@ncteisen
Copy link
Copy Markdown
Contributor

@ncteisen ncteisen commented Aug 3, 2018

@ncteisen ncteisen added kind/bug priority/P1 lang/core disposition/BUILDNURSE For all buildnurse related build/test failures and flakes release notes: no Indicates if PR should not be in release notes labels Aug 3, 2018
@ncteisen ncteisen requested a review from hcaseyal August 3, 2018 20:30
@ncteisen
Copy link
Copy Markdown
Contributor Author

ncteisen commented Aug 3, 2018

Duplicate of #16243

@ncteisen ncteisen marked this as a duplicate of #16243 Aug 3, 2018
@ncteisen ncteisen closed this Aug 3, 2018
@grpc-testing
Copy link
Copy Markdown

****************************************************************

libgrpc.so

     VM SIZE                                                                   FILE SIZE
 ++++++++++++++ GROWING                                                     ++++++++++++++

 -------------- SHRINKING                                                   --------------
  -0.1%     -16 src/core/ext/transport/chttp2/transport/chttp2_transport.cc     -16  -0.1%
      -2.5%     -16 grpc_chttp2_complete_closure_step                               -16  -2.5%

 -+-+-+-+-+-+-+ MIXED                                                       +-+-+-+-+-+-+-
  +0.0%     +16 [None]                                                          -32  -0.0%

  [ = ]       0 TOTAL                                                           -48  -0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]



@grpc-testing
Copy link
Copy Markdown

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,980,675      Total (<)      1,980,683

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,811,769      Total (>)     10,811,757

 No significant differences in binary sizes


@grpc-testing
Copy link
Copy Markdown

[microbenchmarks] Performance differences noted:
Benchmark                                       cpu_time    real_time
----------------------------------------------  ----------  -----------
BM_PumpStreamClientToServer<InProcess>/2097152  +6%         +6%

@lock lock bot locked as resolved and limited conversation to collaborators Nov 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

disposition/BUILDNURSE For all buildnurse related build/test failures and flakes kind/bug lang/core priority/P1 release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants