Skip to content

Make all ObjC tests intermediate files into /tmpfs#16180

Merged
muxi merged 1 commit intogrpc:masterfrom
muxi:tmpfs-all-objc
Jul 30, 2018
Merged

Make all ObjC tests intermediate files into /tmpfs#16180
muxi merged 1 commit intogrpc:masterfrom
muxi:tmpfs-all-objc

Conversation

@muxi
Copy link
Copy Markdown
Contributor

@muxi muxi commented Jul 30, 2018

To resolve ObjC test failures complaining "no space left on device".

Fixes #16156 .

@muxi muxi added the lang/ObjC label Jul 30, 2018
@muxi muxi requested a review from adelez July 30, 2018 18:48
@muxi muxi added the release notes: no Indicates if PR should not be in release notes label Jul 30, 2018
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jul 30, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jul 30, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jul 30, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,976,654      Total (=)      1,976,654

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,775,727      Total (<)     10,775,730

 No significant differences in binary sizes

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jul 30, 2018 

[microbenchmarks] No significant performance differences

@muxi
Copy link
Copy Markdown
Contributor Author

muxi commented Jul 30, 2018

Only affects Mac tests; failures unrelated.

@muxi muxi merged commit 682d093 into grpc:master Jul 30, 2018
@muxi muxi deleted the tmpfs-all-objc branch July 30, 2018 23:13
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@adelez adelez adelez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adelez adelez

Labels

lang/ObjC release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Several objc tests failing to build because "No space left on device"

3 participants

@muxi @grpc-testing @adelez