Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

• User @a-musing-moose isn't covered by a CLA. They will need to complete the form at https://identity.linuxfoundation.org/projects/cncf

Regards,
CLA GitHub bot

Thanks for the PR!

(Note to self: watch the distribtests suite on master to ensure Python distribtests pass on all platforms after this change)

Our distribtests are failing. Does Python2 pick up extra_requires? https://source.cloud.google.com/results/invocations/d4d49c90-e863-4533-b000-ae8627d83023/targets/grpc%2Fcore%2Fmaster%2Flinux%2Fgrpc_distribtests/log

Apologies. Are you using a recent version of setuptools for the installation? I believe it needs to be fairly recent.

An alternative is to use environmental markers in the install_requires section: https://setuptools.readthedocs.io/en/latest/setuptools.html#declaring-platform-specific-dependencies. But again this requires as recent version of setuptools.

We have a bunch of docker images that we use to test our package installation: https://github.com/grpc/grpc/tree/master/tools/dockerfile/distribtest/

I'm not up to date with the state of affairs with setuptools but perhaps we could do both extra_requires and the current one? I am open to most solutions as long as you can verify them to work with the dockerfiles under python_* directories under the URL above.

FYI https://github.com/grpc/grpc/blob/master/test/distrib/python/test_packages.sh is the test we run within those docker images.

Thanks @mehrdada. I will spend some more time on it today and make sure I can verify using the docker images.