Skip to content

Build python3.7 32-bit packages on Windows#16111

Closed
mehrdada wants to merge 2 commits intogrpc:masterfrom
mehrdada:build-python3.7-windows-32-bit
Closed

Build python3.7 32-bit packages on Windows#16111
mehrdada wants to merge 2 commits intogrpc:masterfrom
mehrdada:build-python3.7-windows-32-bit

Conversation

@mehrdada
Copy link
Copy Markdown
Contributor

@mehrdada mehrdada commented Jul 24, 2018 •
edited
Loading

Addresses #15968 after PyPI package is pushed

Do not merge, pending build infrastructure preinstalling Python3.7

@mehrdada mehrdada requested a review from jtattermusch July 24, 2018 14:24
jtattermusch
jtattermusch approved these changes Jul 24, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@grpc grpc deleted a comment from grpc-testing Aug 6, 2018
@grpc grpc deleted a comment from grpc-testing Aug 6, 2018
@grpc grpc deleted a comment from grpc-testing Aug 6, 2018
@grpc grpc deleted a comment from grpc-testing Aug 6, 2018
@grpc grpc deleted a comment from grpc-testing Aug 6, 2018
@grpc grpc deleted a comment from grpc-testing Aug 6, 2018
@grpc grpc deleted a comment from grpc-testing Aug 6, 2018
@grpc grpc deleted a comment from grpc-testing Aug 6, 2018
@grpc grpc deleted a comment from grpc-testing Aug 6, 2018
@grpc grpc deleted a comment from grpc-testing Aug 6, 2018
@grpc grpc deleted a comment from grpc-testing Aug 6, 2018
@grpc grpc deleted a comment from grpc-testing Aug 6, 2018
@grpc grpc deleted a comment from grpc-testing Aug 6, 2018
@grpc grpc deleted a comment from grpc-testing Aug 6, 2018
@grpc grpc deleted a comment from grpc-testing Aug 6, 2018
@grpc grpc deleted a comment from grpc-testing Aug 6, 2018
@grpc grpc deleted a comment from grpc-testing Aug 6, 2018
@grpc grpc deleted a comment from grpc-testing Aug 6, 2018
@grpc grpc deleted a comment from grpc-testing Aug 6, 2018
@grpc grpc deleted a comment from grpc-testing Aug 6, 2018
@grpc grpc deleted a comment from grpc-testing Aug 6, 2018
@grpc grpc deleted a comment from grpc-testing Aug 6, 2018
@grpc grpc deleted a comment from grpc-testing Aug 6, 2018
@grpc grpc deleted a comment from grpc-testing Aug 6, 2018
@grpc grpc deleted a comment from grpc-testing Aug 6, 2018
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 6, 2018 

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 6, 2018 

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,980,683      Total (=)      1,980,683

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,811,766      Total (<)     10,811,769

 No significant differences in binary sizes

@mehrdada mehrdada mentioned this pull request Aug 6, 2018
Merged
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Aug 6, 2018 

[microbenchmarks] No significant performance differences

@mehrdada
Copy link
Copy Markdown
Contributor Author

mehrdada commented Aug 6, 2018

Closing in favor of #16255 as the primary PR and upmerging that one instead.

@mehrdada mehrdada closed this Aug 6, 2018
@mehrdada mehrdada deleted the build-python3.7-windows-32-bit branch August 6, 2018 18:49
@lock lock bot locked as resolved and limited conversation to collaborators Nov 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jtattermusch jtattermusch jtattermusch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jtattermusch jtattermusch

Labels

area/build area/packaging & distribution kind/enhancement lang/Python priority/P2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mehrdada @grpc-testing @jtattermusch @kokoro-team