Skip to content

Bump to v1.13.0#15895

Merged
srini100 merged 2 commits intogrpc:v1.13.xfrom
srini100:v1.13.x
Jun 28, 2018
Merged

Bump to v1.13.0#15895
srini100 merged 2 commits intogrpc:v1.13.xfrom
srini100:v1.13.x

Conversation

@srini100
Copy link
Copy Markdown
Contributor

@srini100 srini100 commented Jun 27, 2018

No description provided.

@srini100 srini100 requested a review from mehrdada June 27, 2018 19:02
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 27, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE                                    FILE SIZE
 ++++++++++++++ GROWING                      ++++++++++++++

 -------------- SHRINKING                    --------------
 -11.5%     -11 src/cpp/common/version_cc.cc     -11 -11.5%
     -22.0%     -11 grpc::Version[abi:cxx11]         -11 -22.0%

 -+-+-+-+-+-+-+ MIXED                        +-+-+-+-+-+-+-
  +0.0%     +11 [None]                          -109  -0.0%

  [ = ]       0 TOTAL                           -120  -0.0%

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 27, 2018 

[trickle] No significant performance differences

@mehrdada
Copy link
Copy Markdown
Contributor

mehrdada commented Jun 27, 2018

@ZhouyihaiDing I saw comments passing by that some PHP related things are not being regenerated correctly. Not sure if this is relevant, but please take a look at this PR and ensure this is done correctly (although it might not apply to this at all, since no code is changed and this is just a version bump). Thanks!

@ZhouyihaiDing
Copy link
Copy Markdown
Contributor

ZhouyihaiDing commented Jun 27, 2018

Hi @mehrdada .
We submit a PHP only PR to v1.13.x today in order to support the GCP extension launch this week.
#15749
Will it break the v1.13.0 bump?

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 27, 2018 

[microbenchmarks] No significant performance differences

@mehrdada
Copy link
Copy Markdown
Contributor

mehrdada commented Jun 27, 2018

@ZhouyihaiDing Please talk to @srini100 about this. He is managing the release this time and he gets to call the shots.

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 27, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE                                    FILE SIZE
 ++++++++++++++ GROWING                      ++++++++++++++

 -------------- SHRINKING                    --------------
 -11.5%     -11 src/cpp/common/version_cc.cc     -11 -11.5%
     -22.0%     -11 grpc::Version[abi:cxx11]         -11 -22.0%

 -+-+-+-+-+-+-+ MIXED                        +-+-+-+-+-+-+-
  +0.0%     +11 [None]                          -109  -0.0%

  [ = ]       0 TOTAL                           -120  -0.0%

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 27, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 27, 2018 

[microbenchmarks] No significant performance differences

@srini100
Copy link
Copy Markdown
Contributor Author

srini100 commented Jun 27, 2018

@murgatroid99 @nicolasnoble, Basic Tests MacOS [dbg] (internal CI) is failing due to some change on Node side. Can you please look. This is v1.13.x branch which don't have any node related stuff since last build.

@srini100
Copy link
Copy Markdown
Contributor Author

srini100 commented Jun 28, 2018

Bazel Debug build for C/C++ - #15610
Bazel Opt build for C/C++ - #15610
No logs for Bazel ASAN build for C/C++ and Bazel UBSAN build for C/C++. UBsan C and ASAN C are passing. Not caused by this PR which is just a version bump.
Basic Tests MacOS [dbg] (internal CI) and Basic Tests MacOS [opt] (internal CI) are due to picking up incompatible change from grpc-node/master which was in turn due to #15274. There is nothing we can do to fix it on this branch as we don't want to merge #15274 in v1.13.0.

@srini100 srini100 merged commit 5d57a8d into grpc:v1.13.x Jun 28, 2018
@srini100 srini100 deleted the v1.13.x branch June 28, 2018 00:25
@lock lock bot locked as resolved and limited conversation to collaborators Sep 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mehrdada mehrdada mehrdada approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@srini100 @grpc-testing @mehrdada @ZhouyihaiDing @kokoro-team