Skip to content

Set runs_per_test=2 for asan and ubsan, also add them to PR builds#15872

Merged
adelez merged 2 commits intogrpc:masterfrom
adelez:foundry_integration
Jun 26, 2018
Merged

Set runs_per_test=2 for asan and ubsan, also add them to PR builds#15872
adelez merged 2 commits intogrpc:masterfrom
adelez:foundry_integration

Conversation

@adelez
Copy link
Copy Markdown
Contributor

@adelez adelez commented Jun 26, 2018

No description provided.

@adelez adelez requested a review from matt-kwong June 26, 2018 16:55
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 26, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@adelez adelez changed the title Set runs_per_test=2 Set runs_per_test=2 for asan and ubsan, also add them to PR builds Jun 26, 2018
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 26, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 26, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 26, 2018 

[trickle] No significant performance differences

matt-kwong
matt-kwong approved these changes Jun 26, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@matt-kwong matt-kwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after addressing comment

tools/internal_ci/linux/pull_request/grpc_ubsan_on_foundry.sh
--action_env=BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1 \
--extra_toolchains=@com_github_bazelbuild_bazeltoolchains//configs/ubuntu16_04_clang/1.0/bazel_0.13.0/cpp:cc-toolchain-clang-x86_64-default \
--extra_execution_platforms=@com_github_bazelbuild_bazeltoolchains//configs/ubuntu16_04_clang/1.0:rbe_ubuntu1604 \
-- //test/... || FAILED="true"
Copy link
Copy Markdown
Contributor

@matt-kwong matt-kwong Jun 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything from || FAILED="true" onwards can be deleted since we don't want to upload results from PRs

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 26, 2018 

[microbenchmarks] No significant performance differences

@adelez adelez merged commit 2c9d7a6 into grpc:master Jun 26, 2018
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 26, 2018 

[microbenchmarks] No significant performance differences

@lock lock bot locked as resolved and limited conversation to collaborators Sep 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@matt-kwong matt-kwong matt-kwong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adelez @grpc-testing @matt-kwong