Skip to content

Disable Channelz connectivity_state Query for Now#15869

Merged
ncteisen merged 1 commit intogrpc:masterfrom
ncteisen:fix-build
Jun 26, 2018
Merged

Disable Channelz connectivity_state Query for Now#15869
ncteisen merged 1 commit intogrpc:masterfrom
ncteisen:fix-build

Conversation

@ncteisen
Copy link
Copy Markdown
Contributor

@ncteisen ncteisen commented Jun 26, 2018

This is causing a low priority internal build failure. The right fix is a cleanup of how teams depend on gRPC internally. That will take some time, so we should disable this for now.

This is ok since this is a default-off feature that no one is using yet

@ncteisen ncteisen requested a review from markdroth June 26, 2018 15:20
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 26, 2018 

****************************************************************

libgrpc.so

     VM SIZE                                                                  FILE SIZE
 ++++++++++++++ GROWING                                                    ++++++++++++++

 -------------- SHRINKING                                                  --------------
  -0.0%     -16 [None]                                                         -80  -0.0%
  -1.3%     -16 src/core/lib/channel/channelz.cc                               -16  -1.3%
     -22.2%      -8 [Unmapped]                                                      -8 -22.2%
     -36.4%      -8 grpc_core::channelz::ChannelNode::GetConnectivityState          -8 -36.4%

  -0.0%     -32 TOTAL                                                          -96  -0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

1 similar comment
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 26, 2018 

****************************************************************

libgrpc.so

     VM SIZE                                                                  FILE SIZE
 ++++++++++++++ GROWING                                                    ++++++++++++++

 -------------- SHRINKING                                                  --------------
  -0.0%     -16 [None]                                                         -80  -0.0%
  -1.3%     -16 src/core/lib/channel/channelz.cc                               -16  -1.3%
     -22.2%      -8 [Unmapped]                                                      -8 -22.2%
     -36.4%      -8 grpc_core::channelz::ChannelNode::GetConnectivityState          -8 -36.4%

  -0.0%     -32 TOTAL                                                          -96  -0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 26, 2018 

[trickle] No significant performance differences

1 similar comment
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 26, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 26, 2018 

[microbenchmarks] No significant performance differences

1 similar comment
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 26, 2018 

[microbenchmarks] No significant performance differences

@ncteisen ncteisen merged commit de06fc0 into grpc:master Jun 26, 2018
@ncteisen ncteisen deleted the fix-build branch June 26, 2018 16:41
@ncteisen ncteisen added the release notes: no Indicates if PR should not be in release notes label Jul 19, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@markdroth markdroth markdroth approved these changes

Assignees

@markdroth markdroth

Labels

area/channelz kind/bug lang/core priority/P3 release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ncteisen @grpc-testing @markdroth