Skip to content

PHP: fix distribution test by adding 2 header files into the package.xml#15867

Merged
dgquintas merged 1 commit intogrpc:masterfrom
ZhouyihaiDing:15865
Jun 26, 2018
Merged

PHP: fix distribution test by adding 2 header files into the package.xml#15867
dgquintas merged 1 commit intogrpc:masterfrom
ZhouyihaiDing:15865

Conversation

@ZhouyihaiDing
Copy link
Copy Markdown
Contributor

@ZhouyihaiDing ZhouyihaiDing commented Jun 26, 2018 •
edited
Loading

Try to fix #15865.
I update the build.yaml and run buildgen.sh, but it updates more files than I need which I am not sure correct or not. I only want to add 2 *.h files into the package.xml.

@ZhouyihaiDing ZhouyihaiDing requested a review from dgquintas June 26, 2018 00:32
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 26, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@ZhouyihaiDing ZhouyihaiDing changed the title PHP: fix distrib test PHP: fix distribution test by adding 2 header files into the package.xml Jun 26, 2018
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 26, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 26, 2018 

[microbenchmarks] No significant performance differences

dgquintas
dgquintas approved these changes Jun 26, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@dgquintas dgquintas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch! Thank you! Funny only PHP failed due to this...

@dgquintas dgquintas merged commit 01f3d5e into grpc:master Jun 26, 2018
@ZhouyihaiDing ZhouyihaiDing added the release notes: no Indicates if PR should not be in release notes label Jul 26, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dgquintas dgquintas dgquintas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dgquintas dgquintas

Labels

lang/php release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PHP distrib tests failing on linux and macos

3 participants

@ZhouyihaiDing @grpc-testing @dgquintas