Skip to content

Add header back in build.yaml#15866

Merged
AspirinSJL merged 1 commit intogrpc:masterfrom
AspirinSJL:add_header
Jun 26, 2018
Merged

Add header back in build.yaml#15866
AspirinSJL merged 1 commit intogrpc:masterfrom
AspirinSJL:add_header

Conversation

@AspirinSJL
Copy link
Copy Markdown
Contributor

@AspirinSJL AspirinSJL commented Jun 25, 2018

We still need this internally.

@AspirinSJL AspirinSJL requested a review from nicolasnoble June 25, 2018 23:13
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 25, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 25, 2018 

[trickle] No significant performance differences

@AspirinSJL
Copy link
Copy Markdown
Contributor Author

AspirinSJL commented Jun 25, 2018

Thanks!

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 25, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 25, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 26, 2018 

[microbenchmarks] No significant performance differences

@AspirinSJL AspirinSJL merged commit 22318af into grpc:master Jun 26, 2018
@AspirinSJL AspirinSJL deleted the add_header branch June 26, 2018 00:11
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 26, 2018 

[microbenchmarks] No significant performance differences

@AspirinSJL AspirinSJL added the release notes: no Indicates if PR should not be in release notes label Jul 19, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@nicolasnoble nicolasnoble nicolasnoble approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AspirinSJL @grpc-testing @nicolasnoble