Skip to content

Build grpcio-testing alongside Python artifact builds #15819

Merged
mehrdada merged 4 commits intov1.13.xfrom
mmx-grpcio-testing-build
Jun 20, 2018
Merged

Build grpcio-testing alongside Python artifact builds #15819
mehrdada merged 4 commits intov1.13.xfrom
mmx-grpcio-testing-build

Conversation

@mehrdada
Copy link
Copy Markdown
Contributor

@mehrdada mehrdada commented Jun 20, 2018 •
edited
Loading

Fixes #14294

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 20, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 20, 2018 

[trickle] No significant performance differences

@mehrdada mehrdada force-pushed the mmx-grpcio-testing-build branch from 80c5c02 to 846a03b Compare June 20, 2018 16:41
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 20, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 20, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 20, 2018 

[microbenchmarks] No significant performance differences

1 similar comment
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 20, 2018 

[microbenchmarks] No significant performance differences

@mehrdada mehrdada force-pushed the mmx-grpcio-testing-build branch from 846a03b to 650fcb6 Compare June 20, 2018 18:27
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 20, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 20, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 20, 2018 

[microbenchmarks] No significant performance differences

@mehrdada
Copy link
Copy Markdown
Contributor Author

mehrdada commented Jun 20, 2018 •
edited
Loading

Distribtest ID: 3381eeca-f7c8-4eef-b202-84cf0d9f0905

kpayson64
kpayson64 reviewed Jun 20, 2018
View reviewed changes
test/distrib/python/test_packages.sh
REFLECTION_ARCHIVES=("$EXTERNAL_GIT_ROOT"/input_artifacts/grpcio-reflection-[0-9]*.tar.gz)
fi

HEALTH_ARCHIVES=("$EXTERNAL_GIT_ROOT"/input_artifacts/grpcio-health-checking-[0-9]*.tar.gz)
Copy link
Copy Markdown
Contributor

@kpayson64 kpayson64 Jun 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we moving this out of the "binary" "source" checks?

Copy link
Copy Markdown
Contributor Author

@mehrdada mehrdada Jun 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to do it on both binary/source. Those are source-only packages so it wouldn't matter for them anyway, but our users might install them alongside the binary grpcio vs source grpcio and that might be a slightly different environment, (and the test is cheap), so I'd rather run it on every case.

@mehrdada mehrdada merged commit 062f369 into v1.13.x Jun 20, 2018
@mehrdada mehrdada deleted the mmx-grpcio-testing-build branch June 20, 2018 21:41
@ghostwriternr ghostwriternr mentioned this pull request Jul 8, 2018
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Sep 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nathanielmanistaatgoogle nathanielmanistaatgoogle Awaiting requested review from nathanielmanistaatgoogle

1 more reviewer

@kpayson64 kpayson64 kpayson64 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nathanielmanistaatgoogle nathanielmanistaatgoogle

Labels

area/build area/packaging & distribution kind/enhancement lang/Python priority/P2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mehrdada @grpc-testing @kpayson64 @nathanielmanistaatgoogle