Merged
Conversation
apolcyn
reviewed
Jun 18, 2018
Contributor
There was a problem hiding this comment.
nit: can we minimize the change, keep the ActiveCall.client_invoke, and just get rid of the @metadata_tag var?
Contributor
Author
There was a problem hiding this comment.
OK, I got rid of about ActiveCall.client_invoke call.
ganmacs
force-pushed
the
delete-unused-ivar
branch
from
0b3b3f9 to
f15c6f2
Compare
apolcyn
approved these changes
Jun 20, 2018
Contributor
|
#15827 failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleted unused instance variable
@metadata_tag. And MovedActiveCall.client_invokeinto outside of an exclusive lock because there will be no race condition.