Skip to content

Backport 15727 into v1.13.x (Add a null check for the endpoint on shutdown)#15781

Merged
mehrdada merged 1 commit intogrpc:v1.13.xfrom
mehrdada:backport-15727-to-v1.13.x
Jun 15, 2018
Merged

Backport 15727 into v1.13.x (Add a null check for the endpoint on shutdown)#15781
mehrdada merged 1 commit intogrpc:v1.13.xfrom
mehrdada:backport-15727-to-v1.13.x

Conversation

@mehrdada
Copy link
Copy Markdown
Contributor

@mehrdada mehrdada commented Jun 15, 2018

Backport #15727 into v1.13.x to prevent segfaults on binary packages shipped

@mehrdada mehrdada requested review from kpayson64 and markdroth June 15, 2018 15:34
@mehrdada mehrdada mentioned this pull request Jun 15, 2018
Closed
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 15, 2018 

****************************************************************

libgrpc.so

     VM SIZE                                          FILE SIZE
 ++++++++++++++ GROWING                            ++++++++++++++
  +0.6%     +16 src/core/lib/channel/handshaker.cc     +16  +0.6%
      +1.9%     +16 call_next_handshaker_locked            +16  +1.9%

 -------------- SHRINKING                          --------------
  -0.0%     -16 [None]                                 -16  -0.0%

  [ = ]       0 TOTAL                                    0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 15, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 15, 2018 

[microbenchmarks] Performance differences noted:
Benchmark                                                                              cpu_time    real_time
-------------------------------------------------------------------------------------  ----------  -----------
BM_StreamingPingPongWithCoalescingApi<InProcess, NoOpMutator, NoOpMutator>/262144/1/0  -6%         -6%

@mehrdada mehrdada merged commit 1c78de1 into grpc:v1.13.x Jun 15, 2018
@mehrdada mehrdada deleted the backport-15727-to-v1.13.x branch June 15, 2018 20:22
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@markdroth markdroth markdroth approved these changes

@kpayson64 kpayson64 Awaiting requested review from kpayson64

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mehrdada @grpc-testing @markdroth @kpayson64