WIP PHP: add ChannelInterface for GCP extension to maintain channel pool#15761
Closed
ZhouyihaiDing wants to merge 1 commit intogrpc:masterfrom
Closed
WIP PHP: add ChannelInterface for GCP extension to maintain channel pool#15761ZhouyihaiDing wants to merge 1 commit intogrpc:masterfrom
ZhouyihaiDing wants to merge 1 commit intogrpc:masterfrom
Conversation
ZhouyihaiDing
changed the title
This was referenced Jun 14, 2018
Merged
Contributor
Author
|
Close because we can hook the channel through the call invoker: #15749 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should work together with #15749.
I will add tests if this PR and #15749 are approved.
The GCP extension will use ChannelInterface and CallInvoker to maintain a channel pool. The implementation and tests drafts can be seen at PR: add GCP extension support via call invoker