Merged
Conversation
This was referenced Jun 13, 2018
This was referenced Jun 14, 2018
38956a4 to
25f142f
Compare
stanley-cheung
approved these changes
Jun 26, 2018
src/php/lib/Grpc/BaseStub.php
Outdated
Contributor
There was a problem hiding this comment.
channelFactory or should it be createChannelFactory?
Contributor
Author
There was a problem hiding this comment.
Thanks! Can we ship it with this release or is it better to ship it later in 1.13.1?
Contributor
There was a problem hiding this comment.
let's do it in 1.13.0
cc45fda to
30c852c
Compare
48e4fbf to
30c852c
Compare
30c852c to
776e909
Compare
1f6daa0 to
3042c77
Compare
3042c77 to
a7e282e
Compare
Contributor
Author
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hope this works as CallInvoker in C# does.
The original PR for C# is #5928
CallInvokeris described asto get rid of the tight coupling between MathClient and a "real" Channel.as well asallows intercepting of the calls.It should work together with #15761.
I will add tests if this PR and #15761 are approved before merging.
The GCP extension will use ChannelInterface and CallInvoker to maintain a channel pool. The implementation and tests drafts can be seen at PR: add GCP extension support via call invoker
Hi @stanley-cheung , please review this API when you have time. Thanks!
This is the only way I find to hook a self-defined channel as well as intercept pre-process and post-process for each RPC naturally.
The purpose of the GCP extension is picking a channel from the pool inside call->start() and save/delete channel from the channel pool inside call->getStatus().
Code sample: