Skip to content

Add Python 3.7 Linux wheels to artifact build#15632

Merged
mehrdada merged 2 commits intomasterfrom
mmx-test-build-wheel37
Jun 14, 2018
Merged

Add Python 3.7 Linux wheels to artifact build#15632
mehrdada merged 2 commits intomasterfrom
mmx-test-build-wheel37

Conversation

@mehrdada
Copy link
Copy Markdown
Contributor

@mehrdada mehrdada commented Jun 4, 2018 •
edited
Loading

Progress on #15191 for Linux

@mehrdada mehrdada self-assigned this Jun 4, 2018
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 4, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 4, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 4, 2018 

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 14, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 14, 2018 

[trickle] No significant performance differences

@mehrdada mehrdada force-pushed the mmx-test-build-wheel37 branch from 1c6efa5 to a9bcace Compare June 14, 2018 17:36
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 14, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 14, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 14, 2018 

[microbenchmarks] No significant performance differences

matt-kwong
matt-kwong approved these changes Jun 14, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@matt-kwong matt-kwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - if this breaks the existing Python artifact builds, we can revert this and build 3.7 using a separate Dockerfile from the rest.

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 14, 2018 

[microbenchmarks] No significant performance differences

mehrdada added 2 commits June 14, 2018 13:20
@mehrdada
Add Python 3.7 Linux wheels to artifact build
b4f4d29
@mehrdada
Use a Docker image that includes Python3.7rc1
797a062 
In order to build Python3.7 packages for manylinux1
platform, we need our Docker image to include
Python3.7.  Unfortunately, since Python 3.7 is still
in RC1 stage, the official docker image does not
include that Python release, so we temporarily
rely on our own underlying docker image to build.
@mehrdada mehrdada force-pushed the mmx-test-build-wheel37 branch from a9bcace to 797a062 Compare June 14, 2018 20:21
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 14, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 14, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jun 14, 2018 

[microbenchmarks] No significant performance differences

@mehrdada mehrdada merged commit 33baa95 into master Jun 14, 2018
@mehrdada mehrdada deleted the mmx-test-build-wheel37 branch June 14, 2018 21:22
@mehrdada mehrdada mentioned this pull request Jun 14, 2018
Merged
@mehrdada mehrdada added the release notes: yes Indicates if PR needs to be in release notes label Jul 23, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jtattermusch jtattermusch Awaiting requested review from jtattermusch

@nicolasnoble nicolasnoble Awaiting requested review from nicolasnoble

2 more reviewers

@kpayson64 kpayson64 kpayson64 approved these changes

@matt-kwong matt-kwong matt-kwong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mehrdada mehrdada

Labels

area/build area/packaging & distribution kind/enhancement lang/Python priority/P1 release notes: yes Indicates if PR needs to be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mehrdada @grpc-testing @kpayson64 @matt-kwong @kokoro-team