Skip to content

Log error message for debugging #13650#15527

Merged
yashykt merged 1 commit intogrpc:masterfrom
yashykt:httpsclihelp
May 24, 2018
Merged

Log error message for debugging #13650#15527
yashykt merged 1 commit intogrpc:masterfrom
yashykt:httpsclihelp

Conversation

@yashykt
Copy link
Copy Markdown
Member

@yashykt yashykt commented May 23, 2018

Log error message for debugging #13650

@yashykt yashykt requested a review from jtattermusch May 23, 2018 22:54
jtattermusch
jtattermusch approved these changes May 23, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but note that the request times out, so there might be nothing to print?

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented May 23, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@yashykt
Copy link
Copy Markdown
Member Author

yashykt commented May 23, 2018

There are two places where the deadline takes into effect - one is where it tries to connect to the server and the other is where it tries to perform a handshake. In either cases, it'll be nice to know why exactly it couldn't complete the task.

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented May 23, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented May 23, 2018 

[microbenchmarks] No significant performance differences

@yashykt
Copy link
Copy Markdown
Member Author

yashykt commented May 24, 2018

Known issues : #15457, #12490

@yashykt yashykt mentioned this pull request May 24, 2018
Closed
@yashykt yashykt merged commit f9035be into grpc:master May 24, 2018
@yashykt yashykt added the release notes: no Indicates if PR should not be in release notes label Jul 19, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 17, 2018
@yashykt yashykt deleted the httpsclihelp branch October 26, 2018 20:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jtattermusch jtattermusch jtattermusch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jtattermusch jtattermusch

Labels

release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yashykt @grpc-testing @jtattermusch