Skip to content

Fixing make_grpcio_tools.py#15525

Merged
jtattermusch merged 3 commits intogrpc:masterfrom
jtattermusch:fixing_grpcio_tools
May 23, 2018
Merged

Fixing make_grpcio_tools.py#15525
jtattermusch merged 3 commits intogrpc:masterfrom
jtattermusch:fixing_grpcio_tools

Conversation

@jtattermusch
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch commented May 23, 2018 •
edited
Loading

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented May 23, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented May 23, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented May 23, 2018 

[microbenchmarks] No significant performance differences

matt-kwong
matt-kwong approved these changes May 23, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@matt-kwong matt-kwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtattermusch jtattermusch merged commit 515908b into grpc:master May 23, 2018
@jtattermusch jtattermusch mentioned this pull request May 24, 2018
Merged
@jtattermusch
Copy link
Copy Markdown
Contributor Author

jtattermusch commented May 31, 2018

This was progress towards #14862

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nicolasnoble nicolasnoble Awaiting requested review from nicolasnoble

1 more reviewer

@matt-kwong matt-kwong matt-kwong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtattermusch @grpc-testing @matt-kwong