Skip to content

Add more failure logging to client_lb_end2end_test#15523

Merged
kpayson64 merged 1 commit intogrpc:masterfrom
kpayson64:client_lb_flake
May 23, 2018
Merged

Add more failure logging to client_lb_end2end_test#15523
kpayson64 merged 1 commit intogrpc:masterfrom
kpayson64:client_lb_flake

Conversation

@kpayson64
Copy link
Copy Markdown
Contributor

@kpayson64 kpayson64 commented May 23, 2018

Tries to add more failure logging to drill down on
#15500

Also increases the RPC timeout in case that is what is causing the flake.

@kpayson64 kpayson64 requested a review from jtattermusch May 23, 2018 16:40
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented May 23, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented May 23, 2018 

[trickle] No significant performance differences

jtattermusch
jtattermusch approved these changes May 23, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented May 23, 2018 

[microbenchmarks] No significant performance differences

@kpayson64 kpayson64 merged commit 5883569 into grpc:master May 23, 2018
@kpayson64 kpayson64 mentioned this pull request May 25, 2018
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jtattermusch jtattermusch jtattermusch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kpayson64 @grpc-testing @jtattermusch