Skip to content

Create GRPC_USE_TRACERS to support OSS/internal difference#15516

Merged
ncteisen merged 1 commit intogrpc:masterfrom
ncteisen:cull-the-tracers
May 23, 2018
Merged

Create GRPC_USE_TRACERS to support OSS/internal difference#15516
ncteisen merged 1 commit intogrpc:masterfrom
ncteisen:cull-the-tracers

Conversation

@ncteisen
Copy link
Copy Markdown
Contributor

@ncteisen ncteisen commented May 23, 2018

This will match with an internal change, I will send it to you also

@ncteisen ncteisen requested a review from yashykt May 23, 2018 01:32
@ncteisen
Copy link
Copy Markdown
Contributor Author

ncteisen commented May 23, 2018

Worth noting, this changes nothing in OSS. Tracers are still on by default. This structure just makes the internal part of this easier and cleaner

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented May 23, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented May 23, 2018 

[trickle] No significant performance differences

@ncteisen ncteisen mentioned this pull request May 23, 2018
Closed
yashykt
yashykt approved these changes May 23, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@yashykt yashykt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented May 23, 2018 

[microbenchmarks] No significant performance differences

@ncteisen
Copy link
Copy Markdown
Contributor Author

ncteisen commented May 23, 2018

#15458

@ncteisen ncteisen merged commit 1bd0deb into grpc:master May 23, 2018
@ncteisen ncteisen deleted the cull-the-tracers branch May 23, 2018 21:10
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yashykt yashykt yashykt approved these changes

Assignees

@yashykt yashykt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ncteisen @grpc-testing @yashykt