Skip to content

upload coverage reports as a zip file#15503

Merged
jtattermusch merged 1 commit intogrpc:masterfrom
jtattermusch:coverage_report_as_zip
May 23, 2018
Merged

upload coverage reports as a zip file#15503
jtattermusch merged 1 commit intogrpc:masterfrom
jtattermusch:coverage_report_as_zip

Conversation

@jtattermusch
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch commented May 22, 2018

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented May 22, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

matt-kwong
matt-kwong reviewed May 22, 2018
View reviewed changes
tools/internal_ci/linux/grpc_coverage.sh Outdated
Copy link
Copy Markdown
Contributor

@matt-kwong matt-kwong May 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to track whether this command fails, and exit the script appropriately to reflect whether the tests pass.

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented May 22, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented May 22, 2018 

[microbenchmarks] No significant performance differences

@jtattermusch jtattermusch force-pushed the coverage_report_as_zip branch from f80f226 to 13b50ac Compare May 23, 2018 04:55
@jtattermusch
Copy link
Copy Markdown
Contributor Author

jtattermusch commented May 23, 2018

PTAL.

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented May 23, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented May 23, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented May 23, 2018 

[microbenchmarks] No significant performance differences

matt-kwong
matt-kwong approved these changes May 23, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@matt-kwong matt-kwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtattermusch jtattermusch merged commit 40494bb into grpc:master May 23, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@matt-kwong matt-kwong matt-kwong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@matt-kwong matt-kwong

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtattermusch @grpc-testing @matt-kwong