Skip to content

Update grpcio_tools in build_protobuf_at_head build#15492

Merged
jtattermusch merged 2 commits intogrpc:masterfrom
jtattermusch:python_protobuf_at_head
May 24, 2018
Merged

Update grpcio_tools in build_protobuf_at_head build#15492
jtattermusch merged 2 commits intogrpc:masterfrom
jtattermusch:python_protobuf_at_head

Conversation

@jtattermusch
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch commented May 21, 2018

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented May 21, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented May 21, 2018 

[trickle] No significant performance differences

@jtattermusch
Copy link
Copy Markdown
Contributor Author

jtattermusch commented May 21, 2018

I am seeing this problem when running make_grpcio_tools.py. Any tips?

Extracting Bazel installation...
...........
ERROR: /src/grpc/third_party/protobuf/BUILD:278:1: in cc_library rule //:protoc_lib: cycle in dependency graph:
.-> //:protoc_lib
|   //:protobuf
|   //:src/google/protobuf/unittest_lazy_dependencies.pb.h
|   //:cc_test_protos_genproto
|   //:protoc
`-- //:protoc_lib
ERROR: Loading of target '//:protoc_lib' failed; build aborted
ERROR: Evaluation of query "deps(//:protoc_lib)" failed due to BUILD file errors
Got non-fatal error:
Traceback (most recent call last):
  File "tools/distrib/python/make_grpcio_tools.py", line 159, in main
    protoc_lib_deps_content = get_deps()
  File "tools/distrib/python/make_grpcio_tools.py", line 108, in get_deps
    cc_files_output = bazel_query(BAZEL_DEPS_PROTOC_LIB_QUERY)
  File "tools/distrib/python/make_grpcio_tools.py", line 101, in bazel_query
    output = subprocess.check_output([BAZEL_DEPS, query])
  File "/usr/lib/python2.7/subprocess.py", line 219, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
CalledProcessError: Command '['/usr/local/google/home/jtattermusch/github/grpc/tools/distrib/python/bazel_deps.sh', '//:protoc_lib']' returned non-zero exit status 7

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented May 21, 2018 

[microbenchmarks] No significant performance differences

@mehrdada
Copy link
Copy Markdown
Contributor

mehrdada commented May 21, 2018

I have certainly encountered this error a long time ago in flakes on Sanity (#13404) and fixed it by improving the process and avoiding the bazel query altogether while running Sanity tests (#13463). There might be an issue with the docker image being old or something? I never quite got to the root of it. That whole rube-goldberg machine to build grpcio-tools is indeed a pain.

@jtattermusch jtattermusch mentioned this pull request May 23, 2018
Merged
@jtattermusch jtattermusch force-pushed the python_protobuf_at_head branch from a654d3f to f7c6a57 Compare May 23, 2018 23:17
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented May 23, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented May 23, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented May 24, 2018 

[microbenchmarks] No significant performance differences

@jtattermusch jtattermusch force-pushed the python_protobuf_at_head branch from f7c6a57 to f0202de Compare May 24, 2018 19:16
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented May 24, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented May 24, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented May 24, 2018 

[microbenchmarks] No significant performance differences

@jtattermusch jtattermusch merged commit 374a5e8 into grpc:master May 24, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
@lock lock bot unassigned mehrdada Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mehrdada mehrdada mehrdada approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtattermusch @grpc-testing @mehrdada