Add load reporter for server load reporting by AspirinSJL · Pull Request #15196 · grpc/grpc

AspirinSJL · 2018-04-26T18:14:13Z

This is a continuation of #14793 ~~and currently based on that PR~~.

~~This is not yet ready for review. I hope to see some quick feedback from @isturdy on my usage of the opencensus APIs.~~

This is ready for review except for the get_cpu_stats() implementation on the platforms other than Linux.

I skipped some low-risk but detailed tests for now.

This change is

AspirinSJL · 2018-04-26T18:15:32Z

src/cpp/server/load_reporter/load_reporter.cc

@isturdy This is how I create the views.

AspirinSJL · 2018-04-26T18:16:18Z

src/cpp/server/load_reporter/load_reporter.cc

@isturdy This is how I process the ViewData.

AspirinSJL · 2018-04-26T18:17:22Z

src/cpp/server/load_reporter/load_reporter.cc

@isturdy This is how I fetch the data.

grpc-testing · 2018-04-26T18:26:43Z

[trickle] No significant performance differences

grpc-testing · 2018-04-26T19:07:46Z

[microbenchmarks] No significant performance differences

isturdy

Apologies for missing this previously--just one comment, if it is still relevant.

isturdy · 2018-05-17T23:53:54Z

src/cpp/server/load_reporter/load_reporter.h

You should be able to replace all these imports with "third_party/opencensus-cpp/opencensus/stats/stats.h"

Got it. Thanks!

grpc-testing · 2018-05-24T18:25:23Z

[trickle] No significant performance differences

grpc-testing · 2018-05-24T19:07:21Z

[microbenchmarks] No significant performance differences

grpc-testing · 2018-05-24T21:45:44Z

[trickle] No significant performance differences

grpc-testing · 2018-05-24T22:29:10Z

[microbenchmarks] No significant performance differences

grpc-testing · 2018-05-24T22:30:21Z

[trickle] No significant performance differences

grpc-testing · 2018-05-24T23:13:14Z

[microbenchmarks] No significant performance differences

grpc-testing · 2018-05-25T04:41:46Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

grpc-testing · 2018-05-25T04:43:49Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

AspirinSJL · 2018-05-25T04:48:31Z

WORKSPACE

 grpc_deps()
 grpc_test_only_deps()
+
+http_archive(


@nicolasnoble Is the change in this file OK?

grpc-testing · 2018-05-25T04:50:27Z

[trickle] No significant performance differences

grpc-testing · 2018-05-25T04:50:43Z

[trickle] No significant performance differences

grpc-testing · 2018-05-25T05:04:18Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

grpc-testing · 2018-05-25T05:13:31Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

grpc-testing · 2018-05-25T05:14:12Z

[trickle] No significant performance differences

grpc-testing · 2018-05-25T05:21:13Z

[trickle] No significant performance differences

grpc-testing · 2018-05-25T05:33:54Z

[microbenchmarks] No significant performance differences

grpc-testing · 2018-05-25T05:35:20Z

[microbenchmarks] No significant performance differences

grpc-testing · 2018-05-25T05:56:39Z

[microbenchmarks] No significant performance differences

grpc-testing · 2018-05-25T06:05:14Z

[microbenchmarks] No significant performance differences

grpc-testing · 2018-05-25T19:22:28Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

grpc-testing · 2018-06-21T02:19:47Z

[microbenchmarks] No significant performance differences

grpc-testing · 2018-06-21T18:50:11Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

AspirinSJL · 2018-06-21T18:50:51Z

Cool! I've cleaned it up. This PR is ready for a final review now. @yetianx @markroth.

Review status: 17 of 18 files reviewed, 4 unresolved discussions (waiting on @markdroth, @yetianx, @summerxyt, and @nicolasnoble)

build.yaml, line 1894 at r1 (raw file):

Previously, markdroth (Mark D. Roth) wrote…

Still need feedback from @nicolasnoble about this.

Done. @nicolasnoble says the Bazel tests are running well. So I have removed these targets here.

Comments from Reviewable

grpc-testing · 2018-06-21T18:56:55Z

[trickle] No significant performance differences

AspirinSJL · 2018-06-21T19:07:56Z

Squashing. (Heads-up to @yetianx)

grpc-testing · 2018-06-21T19:43:01Z

[microbenchmarks] No significant performance differences

grpc-testing · 2018-06-21T20:06:59Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

AspirinSJL · 2018-06-21T20:09:22Z

I have one small change between approval and squashing.

We already have OpenCensus dependency set up after #15070. So I removed my change to WORKSPACE and followed #15070 to add an external_deps.

grpc-testing · 2018-06-21T20:14:59Z

[trickle] No significant performance differences

grpc-testing · 2018-06-21T20:25:23Z

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

grpc-testing · 2018-06-21T20:34:03Z

[trickle] No significant performance differences

grpc-testing · 2018-06-21T20:58:26Z

[microbenchmarks] No significant performance differences

grpc-testing · 2018-06-21T21:17:04Z

[microbenchmarks] No significant performance differences

AspirinSJL · 2018-06-21T22:38:41Z

Basic Tests MacOS [opt] (internal CI): #15027

AspirinSJL added the disposition/Work In Progress label Apr 26, 2018

AspirinSJL commented Apr 26, 2018

View reviewed changes

isturdy reviewed May 17, 2018

View reviewed changes

AspirinSJL force-pushed the load_reporter branch from 39c7ace to fb2167c Compare May 24, 2018 18:12

AspirinSJL requested review from markdroth and summerxyt May 25, 2018 04:42

AspirinSJL requested a review from nicolasnoble May 25, 2018 04:47

AspirinSJL commented May 25, 2018

View reviewed changes

AspirinSJL removed the disposition/Work In Progress label May 25, 2018

markdroth approved these changes Jun 21, 2018

View reviewed changes

AspirinSJL removed the request for review from summerxyt June 21, 2018 19:10

AspirinSJL force-pushed the load_reporter branch from daad65e to 27d6dee Compare June 21, 2018 20:03

Add load reporter

291bbc7

AspirinSJL force-pushed the load_reporter branch from 27d6dee to 291bbc7 Compare June 21, 2018 20:21

AspirinSJL merged commit 8bda53e into grpc:master Jun 21, 2018

AspirinSJL deleted the load_reporter branch June 21, 2018 22:38

AspirinSJL added release notes: yes Indicates if PR needs to be in release notes lang/c++ release notes: no Indicates if PR should not be in release notes and removed lang/c++ release notes: yes Indicates if PR needs to be in release notes labels Jul 19, 2018

lock bot locked as resolved and limited conversation to collaborators Oct 22, 2018

Conversation

AspirinSJL commented Apr 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AspirinSJL Apr 26, 2018

Choose a reason for hiding this comment

Uh oh!

AspirinSJL Apr 26, 2018

Choose a reason for hiding this comment

Uh oh!

AspirinSJL Apr 26, 2018

Choose a reason for hiding this comment

Uh oh!

grpc-testing commented Apr 26, 2018

Uh oh!

grpc-testing commented Apr 26, 2018

Uh oh!

isturdy left a comment

Choose a reason for hiding this comment

Uh oh!

isturdy May 17, 2018

Choose a reason for hiding this comment

Uh oh!

AspirinSJL May 18, 2018

Choose a reason for hiding this comment

Uh oh!

grpc-testing commented May 24, 2018

Uh oh!

grpc-testing commented May 24, 2018

Uh oh!

grpc-testing commented May 24, 2018

Uh oh!

grpc-testing commented May 24, 2018

Uh oh!

grpc-testing commented May 24, 2018

Uh oh!

grpc-testing commented May 24, 2018

Uh oh!

grpc-testing commented May 25, 2018

Uh oh!

grpc-testing commented May 25, 2018

Uh oh!

AspirinSJL May 25, 2018

Choose a reason for hiding this comment

Uh oh!

grpc-testing commented May 25, 2018

Uh oh!

grpc-testing commented May 25, 2018

Uh oh!

grpc-testing commented May 25, 2018

Uh oh!

grpc-testing commented May 25, 2018

Uh oh!

grpc-testing commented May 25, 2018

Uh oh!

grpc-testing commented May 25, 2018

Uh oh!

grpc-testing commented May 25, 2018

Uh oh!

grpc-testing commented May 25, 2018

Uh oh!

grpc-testing commented May 25, 2018

Uh oh!

grpc-testing commented May 25, 2018

Uh oh!

grpc-testing commented May 25, 2018

Uh oh!

grpc-testing commented Jun 21, 2018

Uh oh!

grpc-testing commented Jun 21, 2018

Uh oh!

AspirinSJL commented Jun 21, 2018

Uh oh!

grpc-testing commented Jun 21, 2018

Uh oh!

AspirinSJL commented Jun 21, 2018

Uh oh!

grpc-testing commented Jun 21, 2018

Uh oh!

grpc-testing commented Jun 21, 2018

AspirinSJL commented Apr 26, 2018 •

edited

Loading