Skip to content

Add logging for helping debug httpcli tests#14700

Merged
yashykt merged 1 commit intogrpc:masterfrom
yashykt:httpsclitestlog
Mar 13, 2018
Merged

Add logging for helping debug httpcli tests#14700
yashykt merged 1 commit intogrpc:masterfrom
yashykt:httpsclitestlog

Conversation

@yashykt
Copy link
Copy Markdown
Member

@yashykt yashykt commented Mar 13, 2018

No description provided.

@yashykt yashykt requested a review from AspirinSJL March 13, 2018 22:17
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Mar 13, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Mar 13, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Mar 13, 2018 

[microbenchmarks] No significant performance differences

@yashykt yashykt merged commit 431aea5 into grpc:master Mar 13, 2018
@yashykt yashykt deleted the httpsclitestlog branch March 14, 2018 22:14
@jtattermusch jtattermusch mentioned this pull request Mar 19, 2018
Closed
yashykt added a commit to yashykt/grpc that referenced this pull request May 23, 2018
@yashykt
Log error message for debugging grpc#14700
64321c0
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@AspirinSJL AspirinSJL AspirinSJL approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yashykt @grpc-testing @AspirinSJL