Skip to content

Delete garbage from Python source packages#14533

Merged
mehrdada merged 1 commit intogrpc:v1.10.xfrom
mehrdada:cleangarbage
Feb 27, 2018
Merged

Delete garbage from Python source packages#14533
mehrdada merged 1 commit intogrpc:v1.10.xfrom
mehrdada:cleangarbage

Conversation

@mehrdada
Copy link
Copy Markdown
Contributor

@mehrdada mehrdada commented Feb 27, 2018

No description provided.

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 27, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

1 similar comment
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 27, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 27, 2018 

[trickle] No significant performance differences

1 similar comment
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 27, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 27, 2018 

[microbenchmarks] No significant performance differences

1 similar comment
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 27, 2018 

[microbenchmarks] No significant performance differences

@mehrdada mehrdada changed the base branch from master to v1.10.x February 27, 2018 04:21
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 27, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 27, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 27, 2018 

[microbenchmarks] No significant performance differences

@mehrdada mehrdada requested a review from kpayson64 February 27, 2018 05:35
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 27, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 27, 2018 

[trickle] No significant performance differences

@mehrdada mehrdada merged commit 3c60055 into grpc:v1.10.x Feb 27, 2018
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 27, 2018 

[microbenchmarks] No significant performance differences

@mehrdada mehrdada deleted the cleangarbage branch February 27, 2018 06:59
@mehrdada mehrdada mentioned this pull request Feb 27, 2018
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@kpayson64 kpayson64 kpayson64 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kpayson64 kpayson64

Labels

area/packaging & distribution lang/Python priority/P0/RELEASE BLOCKER

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mehrdada @grpc-testing @kpayson64 @nathanielmanistaatgoogle