Skip to content

Include Boringssl fips_fragments files in headers for building#14515

Merged
matt-kwong merged 1 commit intogrpc:v1.10.xfrom
matt-kwong:fips-frags
Feb 23, 2018
Merged

Include Boringssl fips_fragments files in headers for building#14515
matt-kwong merged 1 commit intogrpc:v1.10.xfrom
matt-kwong:fips-frags

Conversation

@matt-kwong
Copy link
Copy Markdown
Contributor

@matt-kwong matt-kwong commented Feb 23, 2018 •
edited
Loading

Fixes this build issue:

libtool: compile:  cc -fvisibility=hidden -DOPENSSL_NO_ASM -D_GNU_SOURCE -DWIN32_LEAN_AND_MEAN -D_HAS_EXCEPTIONS=0 -DNOMINMAX -DGRPC_ARES=0 -I. -I/tmp/pear/temp/grpc -DPHP_ATOM_INC -I/tmp/pear/temp/pear-build-rootKSKBbQ/grpc-1.10.0RC1/include -I/tmp/pear/temp/pear-build-rootKSKBbQ/grpc-1.10.0RC1/main -I/tmp/pear/temp/grpc -I/usr/include/php/20151012 -I/usr/include/php/20151012/main -I/usr/include/php/20151012/TSRM -I/usr/include/php/20151012/Zend -I/usr/include/php/20151012/ext -I/usr/include/php/20151012/ext/date/lib -I/tmp/pear/temp/grpc/include -I/tmp/pear/temp/grpc/src/php/ext/grpc -I/tmp/pear/temp/grpc/third_party/boringssl/include -DHAVE_CONFIG_H -Wall -Werror -Wno-parentheses-equality -Wno-unused-value -std=c11 -c /tmp/pear/temp/grpc/third_party/boringssl/crypto/fipsmodule/bcm.c  -fPIC -DPIC -o third_party/boringssl/crypto/fipsmodule/.libs/bcm.o
/tmp/pear/temp/grpc/third_party/boringssl/crypto/fipsmodule/bcm.c:35:21: fatal error: aes/aes.c: No such file or directory
compilation terminated.
Makefile:995: recipe for target 'third_party/boringssl/crypto/fipsmodule/bcm.lo' failed

bcm.c includes all files in fipsmodule. We don't need to build these files, but we want to include them in our headers, so that they can be found and not built.

See https://boringssl-review.googlesource.com/c/boringssl/+/16946

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 23, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 23, 2018 

[trickle] No significant performance differences

@stanley-cheung
Copy link
Copy Markdown
Contributor

stanley-cheung commented Feb 23, 2018

LGTM for fixing the PHP build issue at 1.10.0RC1

@matt-kwong
Copy link
Copy Markdown
Contributor Author

matt-kwong commented Feb 23, 2018

Artifact builds were passing for Windows, Linux, and MacOS. Pushed another commit to fix a typo in a comment.

@matt-kwong matt-kwong merged commit 01e5057 into grpc:v1.10.x Feb 23, 2018
@matt-kwong matt-kwong mentioned this pull request Feb 23, 2018
Merged
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 23, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 23, 2018 

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 23, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 24, 2018 

[microbenchmarks] No significant performance differences

@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mehrdada mehrdada mehrdada approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matt-kwong @grpc-testing @stanley-cheung @mehrdada