Fix Linux Artifact builds#14502
Merged
mehrdada merged 1 commit intogrpc:v1.10.xfrom Feb 23, 2018
mehrdada:testdocker
Merged
Conversation
|
|
|
|
|
|
Change `git submodule` copying mechanism from the host to the docker container to use `git clone` instead of `git submodule update --init --reference`, which reaches out to the network and fails on older docker containers with deprecated openssl versions that do not support modern TLS versions required by GitHub, e.g. manylinux1. This fixes artifact builds for protoc and Python on Linux.
Contributor
Author
matt-kwong
approved these changes
Feb 23, 2018
Contributor
matt-kwong
left a comment
matt-kwong
left a comment
There was a problem hiding this comment.
Approving to unblock release
|
|
1 similar comment
|
|
2 similar comments
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
git submodulecopying mechanism from the hostto the docker container to use
git cloneinstead ofgit submodule update --init --reference, which reachesout to the network and fails on older docker containers
with deprecated openssl versions that do not support
modern TLS versions required by GitHub, e.g. manylinux1.
This fixes artifact builds for protoc and Python on Linux.
Fixes #14496 on 1.10 branch.