Skip to content

Revert "grpclb re-resolution"#14356

Merged
AspirinSJL merged 1 commit intomasterfrom
revert-13671-grpclb_reresolution
Feb 7, 2018
Merged

Revert "grpclb re-resolution"#14356
AspirinSJL merged 1 commit intomasterfrom
revert-13671-grpclb_reresolution

Conversation

@AspirinSJL
Copy link
Copy Markdown
Contributor

Reverts #13671

Flake: #14354

@grpc-testing
Copy link
Copy Markdown

****************************************************************

libgrpc.so

     VM SIZE                                                                                            FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
  +0.0%     +85 [None]                                                                               +5.26Ki  +0.1%
      +0.0%     +61 [Unmapped]                                                                           +5.24Ki  +0.1%
     +10.0%      +8 glb_lb_policy_vtable                                                                      +8 +10.0%
     +10.0%      +8 pick_first_lb_policy_vtable                                                               +8 +10.0%
     +10.0%      +8 round_robin_lb_policy_vtable                                                              +8 +10.0%
  +2.2%    +112 src/core/ext/filters/client_channel/lb_policy/pick_first/pick_first.cc                  +112  +2.2%
      [NEW]    +138 start_picking_locked(pick_first_lb_policy*) [clone .isra.1]                             +138  [NEW]
      [NEW]    +112 pf_set_reresolve_closure_locked                                                         +112  [NEW]
      [NEW]     +89 destroy_unselected_subchannels_locked(pick_first_lb_policy*) [clone .isra.2]             +89  [NEW]
  +1.8%    +112 src/core/ext/filters/client_channel/lb_policy/round_robin/round_robin.cc                +112  +1.8%
      [NEW]    +112 rr_set_reresolve_closure_locked                                                         +112  [NEW]
      [NEW]    +105 start_picking_locked(round_robin_lb_policy*) [clone .isra.1]                            +105  [NEW]
  +0.7%     +96 src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc                           +96  +0.7%
      [NEW]    +801 build_lb_channel_args(grpc_lb_addresses const*, grpc_fake_resolver_response_generato    +801  [NEW]
      [NEW]    +303 update_lb_connectivity_status_locked                                                    +303  [NEW]
      [NEW]    +210 extract_backend_addresses_locked(grpc_lb_addresses const*) [clone .isra.2]              +210  [NEW]
      [NEW]    +145 lb_call_data_shutdown(glb_lb_policy*) [clone .isra.4]                                   +145  [NEW]
      [NEW]    +143 glb_set_reresolve_closure_locked                                                        +143  [NEW]
      [NEW]     +98 on_rr_connectivity_changed_locked                                                        +98  [NEW]
      +2.7%     +40 rr_handover_locked(glb_lb_policy*) [clone .part.17]                                      +40  +2.7%
      +4.0%     +32 glb_shutdown_locked                                                                      +32  +4.0%
      +2.3%     +16 glb_update_locked                                                                        +16  +2.3%
      +3.1%     +13 [Unmapped]                                                                               +13  +3.1%
      +2.0%      +8 glb_pick_locked                                                                           +8  +2.0%
      +8.0%      +8 glb_ping_one_locked                                                                       +8  +8.0%
      +3.0%      +8 glb_lb_channel_on_connectivity_changed_cb                                                 +8  +3.0%
      +3.6%      +7 glb_destroy                                                                               +7  +3.6%
       +33%      +3 glb_check_connectivity_locked                                                             +3   +33%
       +33%      +3 glb_notify_on_state_change_locked                                                         +3   +33%

 -------------- SHRINKING                                                                            --------------
  -8.3%     -45 src/core/ext/filters/client_channel/lb_policy.cc                                         -45  -8.3%
     -89.8%     -53 grpc_lb_policy_set_reresolve_closure_locked                                              -53 -89.8%

  +0.0%    +360 TOTAL                                                                                +5.53Ki  +0.1%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]



@grpc-testing
Copy link
Copy Markdown

[trickle] No significant performance differences

@AspirinSJL AspirinSJL merged commit a485cf5 into master Feb 7, 2018
@AspirinSJL AspirinSJL deleted the revert-13671-grpclb_reresolution branch February 7, 2018 18:37
@grpc-testing
Copy link
Copy Markdown

Corrupt JSON data (indicates timeout or crash): 
    bm_fullstack_streaming_pump.BM_PumpStreamServerToClient_SockPair__1.counters.old: 1
    bm_fullstack_streaming_pump.BM_PumpStreamServerToClient_SockPair__512.opt.old: 1


[microbenchmarks] Performance differences noted:
Benchmark                                  cpu_time    real_time
-----------------------------------------  ----------  -----------
BM_ErrorGetPresentInt                      +25%        +25%
BM_HasClearGrpcStatus<ErrorWithHttpError>  -4%         -4%

@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants