Skip to content

Fix the server shutdown code in Fullstack_fixtures#14351

Merged
sreecha merged 1 commit intogrpc:masterfrom
sreecha:bm-epollex-fix
Feb 7, 2018
Merged

Fix the server shutdown code in Fullstack_fixtures#14351
sreecha merged 1 commit intogrpc:masterfrom
sreecha:bm-epollex-fix

Conversation

@sreecha
Copy link
Copy Markdown
Contributor

@sreecha sreecha commented Feb 7, 2018

Fixes #13429
(See comment: #13429 (comment) for more details)

@sreecha
Change the Fixture shutdown code so that the server fds are still polled
3293da3 
(to flush out any writes) when the server is shutdown.
@sreecha sreecha requested a review from yang-g February 7, 2018 08:04
@sreecha sreecha mentioned this pull request Feb 7, 2018
Closed
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 7, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 7, 2018 

[trickle] No significant performance differences

@jtattermusch
Copy link
Copy Markdown
Contributor

jtattermusch commented Feb 7, 2018

@sreecha Great stuff, thanks!

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 7, 2018 

Corrupt JSON data (indicates timeout or crash): 
    bm_fullstack_streaming_pump.BM_PumpStreamServerToClient_SockPair__512.opt.old: 1


[microbenchmarks] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 7, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 7, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 7, 2018 

Corrupt JSON data (indicates timeout or crash): 
    bm_fullstack_streaming_pump.BM_PumpStreamServerToClient_SockPair__8.counters.old: 1


[microbenchmarks] No significant performance differences

@sreecha sreecha merged commit 3261b2d into grpc:master Feb 7, 2018
@sreecha sreecha deleted the bm-epollex-fix branch April 18, 2018 17:24
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@yang-g yang-g yang-g approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sreecha @grpc-testing @jtattermusch @yang-g @kokoro-team