Skip to content

Revert "Partial revert PR#14042"#14342

Merged
muxi merged 1 commit intomasterfrom
revert-14324-revert-14042
Feb 8, 2018
Merged

Revert "Partial revert PR#14042"#14342
muxi merged 1 commit intomasterfrom
revert-14324-revert-14042

Conversation

@muxi
Copy link
Copy Markdown
Contributor

@muxi muxi commented Feb 7, 2018 •
edited
Loading

This PR reverts #14324.

Before I merged in #14324, I found #14314 did make the build green. This PR is to confirm that #14314 along would have fixed the build issue. If that is the case we should merge in this PR.

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 7, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 7, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 7, 2018 

Corrupt JSON data (indicates timeout or crash): 
    bm_fullstack_streaming_pump.BM_PumpStreamServerToClient_SockPair__0.counters.old: 1


[microbenchmarks] No significant performance differences

@muxi muxi requested review from apolcyn and matt-kwong February 7, 2018 17:53
apolcyn
apolcyn approved these changes Feb 7, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@apolcyn apolcyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@muxi muxi merged commit 951cf48 into master Feb 8, 2018
@muxi muxi deleted the revert-14324-revert-14042 branch February 8, 2018 00:45
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@apolcyn apolcyn apolcyn approved these changes

+1 more reviewer

@matt-kwong matt-kwong matt-kwong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@muxi @grpc-testing @apolcyn @matt-kwong