Skip to content

Define the tests as grpc_cc_test to automatically test against all po…#14326

Merged
adelez merged 1 commit intogrpc:masterfrom
adelez:foundry_integration
Feb 6, 2018
Merged

Define the tests as grpc_cc_test to automatically test against all po…#14326
adelez merged 1 commit intogrpc:masterfrom
adelez:foundry_integration

Conversation

@adelez
Copy link
Copy Markdown
Contributor

@adelez adelez commented Feb 5, 2018

…lling strategies

@adelez adelez requested a review from yashykt February 5, 2018 22:27
@adelez adelez mentioned this pull request Feb 5, 2018
Closed
yashykt
yashykt approved these changes Feb 5, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@yashykt yashykt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 5, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 5, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 5, 2018 

Corrupt JSON data (indicates timeout or crash): 
    bm_fullstack_streaming_pump.BM_PumpStreamServerToClient_SockPair__512.opt.old: 1
    bm_fullstack_streaming_pump.BM_PumpStreamServerToClient_SockPair__1.opt.old: 1


[microbenchmarks] No significant performance differences

@adelez adelez merged commit d1b6062 into grpc:master Feb 6, 2018
@adelez adelez mentioned this pull request Feb 6, 2018
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yashykt yashykt yashykt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adelez @grpc-testing @yashykt