Skip to content

Partial revert PR#14042#14324

Merged
muxi merged 1 commit intogrpc:masterfrom
muxi:revert-14042
Feb 5, 2018
Merged

Partial revert PR#14042#14324
muxi merged 1 commit intogrpc:masterfrom
muxi:revert-14042

Conversation

@muxi
Copy link
Copy Markdown
Contributor

@muxi muxi commented Feb 5, 2018

In attempt to fix ObjC master failures in CI.

Copy link
Copy Markdown
Contributor

@matt-kwong matt-kwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if this fixes the MacOS failure

@grpc-testing
Copy link
Copy Markdown

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]



@grpc-testing
Copy link
Copy Markdown

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

Corrupt JSON data (indicates timeout or crash): 
    bm_fullstack_streaming_pump.BM_PumpStreamServerToClient_SockPair__512.opt.old: 1


[microbenchmarks] No significant performance differences

@muxi muxi merged commit 42b6af7 into grpc:master Feb 5, 2018
@muxi muxi deleted the revert-14042 branch February 5, 2018 23:43
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants