Skip to content

Fix reference of self in a block#14314

Merged
muxi merged 3 commits intogrpc:masterfrom
muxi:fix-implicit-retain-self
Feb 5, 2018
Merged

Fix reference of self in a block#14314
muxi merged 3 commits intogrpc:masterfrom
muxi:fix-implicit-retain-self

Conversation

@muxi
Copy link
Copy Markdown
Contributor

@muxi muxi commented Feb 5, 2018

Retain weak self when dispatching block in enqueueSuccessfulCompletion.

Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@muxi muxi force-pushed the fix-implicit-retain-self branch from 890794e to 45ca202 Compare February 5, 2018 21:37
@muxi muxi merged commit cd3f579 into grpc:master Feb 5, 2018
@muxi muxi deleted the fix-implicit-retain-self branch February 5, 2018 23:45
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants