Skip to content

Promote v1.9.0-pre3 to v1.9.0#14265

Merged
mehrdada merged 2 commits intogrpc:v1.9.xfrom
mehrdada:releasetag
Feb 1, 2018
Merged

Promote v1.9.0-pre3 to v1.9.0#14265
mehrdada merged 2 commits intogrpc:v1.9.xfrom
mehrdada:releasetag

Conversation

@mehrdada
Copy link
Copy Markdown
Contributor

@mehrdada mehrdada commented Feb 1, 2018 •
edited
Loading

Tagging the 1.9.0 release! aka "glossy"

@mehrdada mehrdada requested a review from kpayson64 February 1, 2018 00:26
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 1, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE                                    FILE SIZE
 ++++++++++++++ GROWING                      ++++++++++++++

 -------------- SHRINKING                    --------------
 -13.0%     -12 src/cpp/common/version_cc.cc     -12 -13.0%
     -26.1%     -12 grpc::Version[abi:cxx11]         -12 -26.1%

 -+-+-+-+-+-+-+ MIXED                        +-+-+-+-+-+-+-
  +0.0%     +12 [None]                          -212  -0.0%

  [ = ]       0 TOTAL                           -224  -0.0%

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 1, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Feb 1, 2018 

[microbenchmarks] No significant performance differences

@mehrdada
Copy link
Copy Markdown
Contributor Author

mehrdada commented Feb 1, 2018

Test failures:
#13429
#14115

@mehrdada mehrdada merged commit 9b075f1 into grpc:v1.9.x Feb 1, 2018
@mehrdada mehrdada deleted the releasetag branch February 1, 2018 19:36
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@kpayson64 kpayson64 kpayson64 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kpayson64 kpayson64

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mehrdada @grpc-testing @kpayson64