Skip to content

Revert "Merge pull request #13932 from dgquintas/conn_subchannel"#14185

Merged
dgquintas merged 1 commit intogrpc:v1.9.xfrom
nicolasnoble:revert-13932
Jan 26, 2018
Merged

Revert "Merge pull request #13932 from dgquintas/conn_subchannel"#14185
dgquintas merged 1 commit intogrpc:v1.9.xfrom
nicolasnoble:revert-13932

Conversation

@nicolasnoble
Copy link
Copy Markdown
Contributor

@nicolasnoble nicolasnoble commented Jan 25, 2018

This reverts commit a889163, reversing
changes made to 47fe850.

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 25, 2018 

****************************************************************

libgrpc.so

     VM SIZE                                                                                        FILE SIZE
 ++++++++++++++ GROWING                                                                          ++++++++++++++

 -------------- SHRINKING                                                                        --------------
  -0.1%    -765 [None]                                                                           -31.7Ki  -0.5%
      -0.1%    -701 [Unmapped]                                                                       -31.7Ki  -0.5%
      [DEL]     -32 vtable for grpc_core::ConnectedSubchannel                                            -32  [DEL]
      [DEL]     -32 vtable for grpc_core::RefCountedWithTracing                                          -32  [DEL]
 -11.3%    -720 src/core/ext/filters/client_channel/lb_policy/round_robin/round_robin.cc            -720 -11.3%
     -13.9%    -273 rr_connectivity_changed_locked                                                      -273 -13.9%
     -23.4%    -119 rr_ping_one_locked                                                                  -119 -23.4%
     -22.6%    -106 rr_pick_locked                                                                      -106 -22.6%
     -24.1%     -87 rr_cancel_pick_locked                                                                -87 -24.1%
     -21.6%     -82 rr_cancel_picks_locked                                                               -82 -21.6%
     -12.2%     -67 rr_shutdown_locked                                                                   -67 -12.2%
  -6.3%    -384 src/core/ext/filters/client_channel/subchannel.cc                                   -384  -6.3%
      [DEL]    -822 on_subchannel_connected                                                             -822  [DEL]
      [DEL]    -322 grpc_core::ConnectedSubchannel::CreateCall                                          -322  [DEL]
      [DEL]    -290 on_connected_subchannel_connectivity_changed                                        -290  [DEL]
      [DEL]     -76 grpc_core::ConnectedSubchannel::NotifyOnStateChange                                  -76  [DEL]
      [DEL]     -74 grpc_core::ConnectedSubchannel::ConnectedSubchannel                                  -74  [DEL]
      [DEL]     -73 grpc_core::ConnectedSubchannel::Ping                                                 -73  [DEL]
     -89.9%     -71 grpc_subchannel_get_connected_subchannel                                             -71 -89.9%
     -11.1%     -36 grpc_subchannel_unref                                                                -36 -11.1%
     -29.6%     -32 subchannel_call_destroy                                                              -32 -29.6%
      [DEL]     -23 grpc_core::ConnectedSubchannel::~ConnectedSubchannel                                 -23  [DEL]
      [DEL]     -14 grpc_core::ConnectedSubchannel::~ConnectedSubchannel                                 -14  [DEL]
      -3.0%      -8 [Unmapped]                                                                            -8  -3.0%
  -6.4%    -336 src/core/ext/filters/client_channel/lb_policy/pick_first/pick_first.cc              -336  -6.4%
      -8.8%     -94 pf_update_locked                                                                     -94  -8.8%
      [DEL]     -89 destroy_unselected_subchannels_locked(pick_first_lb_policy*) [clone .isra.2]         -89  [DEL]
     -24.1%     -87 pf_cancel_pick_locked                                                                -87 -24.1%
     -12.2%     -67 pf_shutdown_locked                                                                   -67 -12.2%
     -38.3%     -64 pf_pick_locked                                                                       -64 -38.3%
      -1.9%     -29 pf_connectivity_changed_locked                                                       -29  -1.9%
  -1.1%    -160 src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc                      -160  -1.1%
      [DEL] -1.50Ki rr_handover_locked(glb_lb_policy*) [clone .part.11]                              -1.50Ki  [DEL]
      [DEL] -1.36Ki query_for_backends_locked(glb_lb_policy*) [clone .part.13]                       -1.36Ki  [DEL]
     -12.7%    -105 glb_shutdown_locked                                                                 -105 -12.7%
     -16.5%     -62 glb_cancel_pick_locked                                                               -62 -16.5%
  -0.5%     -75 src/core/ext/filters/client_channel/client_channel.cc                                -75  -0.5%
     -18.0%     -68 cc_destroy_call_elem                                                                 -68 -18.0%
      [DEL]      -9 grpc_core::RefCountedWithTracing::~RefCountedWithTracing                              -9  [DEL]
      [DEL]      -2 grpc_core::RefCountedWithTracing::~RefCountedWithTracing                              -2  [DEL]
  -2.8%     -64 src/core/ext/filters/client_channel/lb_policy/subchannel_list.cc                     -64  -2.8%
     -25.0%     -72 grpc_lb_subchannel_data_unref_subchannel                                             -72 -25.0%

  -0.2% -2.45Ki TOTAL                                                                            -33.4Ki  -0.5%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 25, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 25, 2018 

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 26, 2018 

****************************************************************

libgrpc.so

     VM SIZE                                                                                        FILE SIZE
 ++++++++++++++ GROWING                                                                          ++++++++++++++

 -------------- SHRINKING                                                                        --------------
  -0.1%    -765 [None]                                                                           -31.7Ki  -0.5%
      -0.1%    -701 [Unmapped]                                                                       -31.7Ki  -0.5%
      [DEL]     -32 vtable for grpc_core::ConnectedSubchannel                                            -32  [DEL]
      [DEL]     -32 vtable for grpc_core::RefCountedWithTracing                                          -32  [DEL]
 -11.3%    -720 src/core/ext/filters/client_channel/lb_policy/round_robin/round_robin.cc            -720 -11.3%
     -13.9%    -273 rr_connectivity_changed_locked                                                      -273 -13.9%
     -23.4%    -119 rr_ping_one_locked                                                                  -119 -23.4%
     -22.6%    -106 rr_pick_locked                                                                      -106 -22.6%
     -24.1%     -87 rr_cancel_pick_locked                                                                -87 -24.1%
     -21.6%     -82 rr_cancel_picks_locked                                                               -82 -21.6%
     -12.2%     -67 rr_shutdown_locked                                                                   -67 -12.2%
  -6.3%    -384 src/core/ext/filters/client_channel/subchannel.cc                                   -384  -6.3%
      [DEL]    -822 on_subchannel_connected                                                             -822  [DEL]
      [DEL]    -322 grpc_core::ConnectedSubchannel::CreateCall                                          -322  [DEL]
      [DEL]    -290 on_connected_subchannel_connectivity_changed                                        -290  [DEL]
      [DEL]     -76 grpc_core::ConnectedSubchannel::NotifyOnStateChange                                  -76  [DEL]
      [DEL]     -74 grpc_core::ConnectedSubchannel::ConnectedSubchannel                                  -74  [DEL]
      [DEL]     -73 grpc_core::ConnectedSubchannel::Ping                                                 -73  [DEL]
     -89.9%     -71 grpc_subchannel_get_connected_subchannel                                             -71 -89.9%
     -11.1%     -36 grpc_subchannel_unref                                                                -36 -11.1%
     -29.6%     -32 subchannel_call_destroy                                                              -32 -29.6%
      [DEL]     -23 grpc_core::ConnectedSubchannel::~ConnectedSubchannel                                 -23  [DEL]
      [DEL]     -14 grpc_core::ConnectedSubchannel::~ConnectedSubchannel                                 -14  [DEL]
      -3.0%      -8 [Unmapped]                                                                            -8  -3.0%
  -6.4%    -336 src/core/ext/filters/client_channel/lb_policy/pick_first/pick_first.cc              -336  -6.4%
      -8.8%     -94 pf_update_locked                                                                     -94  -8.8%
      [DEL]     -89 destroy_unselected_subchannels_locked(pick_first_lb_policy*) [clone .isra.2]         -89  [DEL]
     -24.1%     -87 pf_cancel_pick_locked                                                                -87 -24.1%
     -12.2%     -67 pf_shutdown_locked                                                                   -67 -12.2%
     -38.3%     -64 pf_pick_locked                                                                       -64 -38.3%
      -1.9%     -29 pf_connectivity_changed_locked                                                       -29  -1.9%
  -1.1%    -160 src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc                      -160  -1.1%
      [DEL] -1.50Ki rr_handover_locked(glb_lb_policy*) [clone .part.11]                              -1.50Ki  [DEL]
      [DEL] -1.36Ki query_for_backends_locked(glb_lb_policy*) [clone .part.13]                       -1.36Ki  [DEL]
     -12.7%    -105 glb_shutdown_locked                                                                 -105 -12.7%
     -16.5%     -62 glb_cancel_pick_locked                                                               -62 -16.5%
  -0.5%     -75 src/core/ext/filters/client_channel/client_channel.cc                                -75  -0.5%
     -18.0%     -68 cc_destroy_call_elem                                                                 -68 -18.0%
      [DEL]      -9 grpc_core::RefCountedWithTracing::~RefCountedWithTracing                              -9  [DEL]
      [DEL]      -2 grpc_core::RefCountedWithTracing::~RefCountedWithTracing                              -2  [DEL]
  -2.8%     -64 src/core/ext/filters/client_channel/lb_policy/subchannel_list.cc                     -64  -2.8%
     -25.0%     -72 grpc_lb_subchannel_data_unref_subchannel                                             -72 -25.0%

  -0.2% -2.45Ki TOTAL                                                                            -33.4Ki  -0.5%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 26, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 26, 2018 

[microbenchmarks] No significant performance differences

@dgquintas
Copy link
Copy Markdown
Contributor

dgquintas commented Jan 26, 2018

issues: #13546 #13445 #13477

@dgquintas dgquintas merged commit 357dc87 into grpc:v1.9.x Jan 26, 2018
@nicolasnoble nicolasnoble deleted the revert-13932 branch January 26, 2018 17:47
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@markdroth markdroth markdroth approved these changes

@dgquintas dgquintas Awaiting requested review from dgquintas

@a11r a11r Awaiting requested review from a11r

Assignees

No one assigned

Labels

priority/P0/RELEASE BLOCKER

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolasnoble @grpc-testing @dgquintas @markdroth