php: fix channel wrapper leak#14130
Merged
stanley-cheung merged 1 commit intogrpc:masterfrom Jan 24, 2018
Merged
Conversation
ZhouyihaiDing
force-pushed
the
wrapper_leak
branch
2 times, most recently
from
7759c5c to
3b4e2de
Compare
ZhouyihaiDing
force-pushed
the
wrapper_leak
branch
from
3b4e2de to
7c647d3
Compare
stanley-cheung
approved these changes
Jan 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is split from PR.
There wasn't place to free channel wrapper allocated here.
In php-fpm mode, each time a channel_wrapper is created, it remains there.
Another solution is use R_SHUTDOWN function to free them after each request.