Skip to content

1.9.0-pre1 is now 1.9.0-pre2#14114

Merged
mehrdada merged 2 commits intogrpc:v1.9.xfrom
jtattermusch:bump_190_pre2
Jan 24, 2018
Merged

1.9.0-pre1 is now 1.9.0-pre2#14114
mehrdada merged 2 commits intogrpc:v1.9.xfrom
jtattermusch:bump_190_pre2

Conversation

@jtattermusch
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch commented Jan 22, 2018

pre2 will contain #14113.

@jtattermusch jtattermusch requested a review from mehrdada January 22, 2018 14:40
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 22, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 22, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 22, 2018 

[microbenchmarks] No significant performance differences

@mehrdada
Copy link
Copy Markdown
Contributor

mehrdada commented Jan 22, 2018

@jtattermusch let's merge this after merging the fix for goaway test failure. perhaps we may want to release rc2 for all langs as opposed to just C#

@mehrdada
Copy link
Copy Markdown
Contributor

mehrdada commented Jan 22, 2018

@jtattermusch let's hold off merging this till after #14122 is merged as well

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 24, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 24, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 24, 2018 

[microbenchmarks] No significant performance differences

@mehrdada
Copy link
Copy Markdown
Contributor

mehrdada commented Jan 24, 2018

Test failures:
Basic Tests C++ Linux [dbg]: #13477 #13429
Basic Tests macOS [dbg]: #14115 #13867
Basic Tests Windows [opt]: #13149
Tsan C++: #13477

@mehrdada mehrdada merged commit 167113f into grpc:v1.9.x Jan 24, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
@lock lock bot unassigned mehrdada Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mehrdada mehrdada mehrdada approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jtattermusch @grpc-testing @mehrdada @kokoro-team