Skip to content

PHP: make generate_projects.sh smarter for package.xml#14098

Merged
stanley-cheung merged 1 commit intogrpc:masterfrom
stanley-cheung:php-smarter-gen-proj
Jan 20, 2018
Merged

PHP: make generate_projects.sh smarter for package.xml#14098
stanley-cheung merged 1 commit intogrpc:masterfrom
stanley-cheung:php-smarter-gen-proj

Conversation

@stanley-cheung
Copy link
Copy Markdown
Contributor

@stanley-cheung stanley-cheung commented Jan 19, 2018

When we are at RC or dev, the PHP package.xml should have the stability beta. Otherwise, the string should be stable.

This is to further minimize the amount of manual work we have to do per release on PECL.

@stanley-cheung stanley-cheung self-assigned this Jan 19, 2018
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 19, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 19, 2018 

[trickle] No significant performance differences

ZhouyihaiDing
ZhouyihaiDing approved these changes Jan 20, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@ZhouyihaiDing ZhouyihaiDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 20, 2018 

Corrupt JSON data (indicates timeout or crash): 
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPong_MinInProcessCHTTP2_NoOpMutator_NoOpMutator__16777216_1.counters.new: 1
    bm_fullstack_unary_ping_pong.BM_UnaryPingPong_InProcessCHTTP2_Client_AddMetadata_RandomBinaryMetadata_10__2__NoOpMutator__0_0.opt.new: 1


[microbenchmarks] No significant performance differences

@stanley-cheung stanley-cheung merged commit 5b48dc7 into grpc:master Jan 20, 2018
@stanley-cheung stanley-cheung deleted the php-smarter-gen-proj branch January 22, 2018 19:03
@stanley-cheung stanley-cheung mentioned this pull request Jan 24, 2018
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ZhouyihaiDing ZhouyihaiDing ZhouyihaiDing approved these changes

Assignees

@stanley-cheung stanley-cheung

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stanley-cheung @grpc-testing @ZhouyihaiDing