Skip to content

Bump to 1.8.5#14053

Merged
nicolasnoble merged 1 commit intogrpc:v1.8.xfrom
stanley-cheung:v1.8.5_bump
Jan 18, 2018
Merged

Bump to 1.8.5#14053
nicolasnoble merged 1 commit intogrpc:v1.8.xfrom
stanley-cheung:v1.8.5_bump

Conversation

@stanley-cheung
Copy link
Copy Markdown
Contributor

@stanley-cheung stanley-cheung commented Jan 17, 2018

No description provided.

@thelinuxfoundation
Copy link
Copy Markdown

thelinuxfoundation commented Jan 17, 2018

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 17, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 17, 2018 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 17, 2018 

[trickle] No significant performance differences

1 similar comment
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 17, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 18, 2018 

[microbenchmarks] No significant performance differences

1 similar comment
@grpc-testing
Copy link
Copy Markdown

grpc-testing commented Jan 18, 2018 

[microbenchmarks] No significant performance differences

@mehrdada
Copy link
Copy Markdown
Contributor

mehrdada commented Jan 18, 2018

I don't have write access to the branch. Assigning to @nicolasnoble. I suggest linking to the existing test failures to make it easy for him

@mehrdada mehrdada assigned nicolasnoble and unassigned mehrdada Jan 18, 2018
@mehrdada mehrdada requested a review from nicolasnoble January 18, 2018 16:44
@ZhouyihaiDing
Copy link
Copy Markdown
Contributor

ZhouyihaiDing commented Jan 18, 2018

Basic Tests Multi-language Linux (internal CI) #13968
Asan C++ (internal CI) #13122
Basic Tests C++ Linux [opt] (internal CI) #13269
Interop Cloud-to-Cloud Tests (internal CI) #13379
Tsan C (internal CI) #14073
Tsan C++ (internal CI) #13381

@nicolasnoble nicolasnoble merged commit db68cb3 into grpc:v1.8.x Jan 18, 2018
@ZhouyihaiDing ZhouyihaiDing mentioned this pull request Jan 18, 2018
Closed
@stanley-cheung stanley-cheung deleted the v1.8.5_bump branch January 18, 2018 18:56
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ZhouyihaiDing ZhouyihaiDing ZhouyihaiDing approved these changes

@nicolasnoble nicolasnoble Awaiting requested review from nicolasnoble

Assignees

@nicolasnoble nicolasnoble

@ZhouyihaiDing ZhouyihaiDing

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@stanley-cheung @thelinuxfoundation @grpc-testing @mehrdada @ZhouyihaiDing @nicolasnoble